Skip to content

RC Generation: Generate intermediate RC files in TEMP #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scheibelp merged 3 commits into from
Apr 29, 2026
Merged

RC Generation: Generate intermediate RC files in TEMP #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02959d0
ld.cxx: use temp dir for RC file creation
johnwparent Apr 29, 2026
d036f4f
cleanup files and ensure unique tmp dir
johnwparent Apr 29, 2026
da2922b
Create temp dir
johnwparent Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/ld.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
#include "ld.h"
#include <minwindef.h>
#include <array>
#include <cstdio>
#include <cstdlib>
#include <cstring>
Expand Down Expand Up @@ -51,6 +52,11 @@ DWORD LdInvocation::InvokeToolchain() {
return ret_code;
}

if(!DeleteFile2A(rc_file.c_str(), FILE_FLAG_DISALLOW_PATH_REDIRECTS)) {
throw std::system_error(static_cast<int>(::GetLastError()),
std::system_category(), "Failed to remove intermediate rc file");
}

// We're creating a PE, we need to create an appropriate import lib
std::string const imp_lib_name = link_run.get_implib_name();

Expand Down Expand Up @@ -167,15 +173,32 @@ std::string LdInvocation::createRC(LinkerInvocation& link_run) {
"BEGIN\n";
const std::string template_end = "END\n";
const std::string pe_name = stripLastExt(basename(pe_stage_name));
const std::string rc_file_name = "spack-" + pe_name + ".rc";
const std::string base_rc_file_name = "spack-" + pe_name + ".rc";

std::array<char, MAX_PATH> temp_dir_buffer;
if (!GetTempPath2A(MAX_PATH, temp_dir_buffer.data())) {
throw std::system_error(static_cast<int>(::GetLastError()),
std::system_category(), "Failed to get TEMP PATH");
}
std::string rc_tmp_dir = join({std::string(temp_dir_buffer.data()), std::to_string(_getpid())}, "");
if(!CreateDirectoryA(rc_tmp_dir.c_str(), NULL)){
DWORD err = ::GetLastError();
if (err != ERROR_ALREADY_EXISTS) {
throw std::system_error(static_cast<int>(err),
std::system_category(), "Failed to make directory");
}
}
// This res file name needs to mirror the PE name _exactly_
// Otherwise the RC file will override the default
// or user set name, violating user expectation
std::string res_file_name = pe_name + ".res";
std::string base_res_file_name = pe_name + ".res";
if (!link_run.get_rc_files().empty()) {
res_file_name = "spack-" + res_file_name;
base_res_file_name = "spack-" + base_res_file_name;
}

const std::string res_file_name = join({rc_tmp_dir, base_rc_file_name}, "\\");
const std::string rc_file_name = join({rc_tmp_dir, base_res_file_name}, "\\");

ExecuteCommand rc_executor("rc",
{"/fo" + res_file_name + " " + rc_file_name});
std::ofstream rc_out(rc_file_name);
Expand All @@ -202,5 +225,9 @@ std::string LdInvocation::createRC(LinkerInvocation& link_run) {
if (err_code != 0) {
throw RCCompilerFailure("Could not compile RC file");
}
if(!DeleteFile2A(rc_file_name.c_str(), FILE_FLAG_DISALLOW_PATH_REDIRECTS)) {
throw std::system_error(static_cast<int>(::GetLastError()),
std::system_category(), "Failed to remove intermediate rc file");
}
return res_file_name;
}
Loading