New command line#29
Conversation
We're no longer modifying binaries on BC push Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
force-pushed
the
new-command-line
branch
from
a669a65 to
6c58737
Compare
Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
One question and one request
| } | ||
|
|
||
| /* | ||
| * Actually performs the DLL rename, given the DLL location in mapped memory view |
There was a problem hiding this comment.
Is this generally handled elsewhere now? given
if (SpackInstalledLib(dll_path)) {
return true;
}
There was a problem hiding this comment.
I think you're referring to the sigil code? No we no longer use that. It occurred to me that at best they served 0 purpose and at worst they were actively making relocation harder from a BC installation.
The primary purpose they serve was to identify whether a given dll reference is from spack or not, we always know it's a spack path by virtue of the fact there is a path. If somehow another tool also does that, the path will need relocation anyway, and if it cant be relocated, then the dll would be broken anyway and we'd want to know about it, so at best they're wasted IO.
At worst, they obliterate the beginning of the dll path, which means when we do relocation and go to re-write the dll names to use the new install prefix, we can't (or its much harder and more fragile) determine the relative path of the dll to the install root as we no longer have the old install root in the dll.
Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I recommend making some doc edits in a follow up
| * | ||
| */ | ||
| bool LibRename::ExecuteRename() { | ||
| // If we're not deploying, we're extracting |
| * | ||
| * \param pe the PE file for which to perform the rename of imported (and exported) DLL names | ||
| * \param full a flag indicating whether or not we're renaming a PE file and import lib or just an import lib | ||
| * \param deploy a flag indicating if we're deploying a binary to a Spack build cache or extracting it |
2 participants
CLI: Remove deploy
We're no longer modifying binaries on BC push
Based on #28