CI PR gating on main (post-flip trunk)#348
Merged
Merged
Conversation
Post-flip, main is the release trunk and PRs target it, but install-e2e.yml and runtime-live-e2e.yml triggered pull_request on [next] only — so a main-PR ran neither the offline go test ./... gate nor the install smoke (only docs.yml). Extend the pull_request branch filter to [next, main] in both. runtime-live-e2e's pull_request trigger is workflow-level, so adding main queues all four jobs on a main-PR, but the three live jobs each declare an approval-gated environment: + needs: offline, so they sit in waiting (no auto-credit-burn). Only the secret-free offline job (go build + go test) runs unconditionally — the same build-runs / deploy-gated split docs.yml uses. Refresh the SECURITY-MODEL header phrase to match the new trigger; the security reasoning is branch-agnostic and unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
clkao
added a commit
that referenced
this pull request
Jun 13, 2026
clkao
added a commit
that referenced
this pull request
Jun 13, 2026
clkao
added a commit
that referenced
this pull request
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate main-PRs on the Go test suite and install smoke, so code cannot reach the post-flip release trunk untested.
What changed
mainto thepull_requestbranch filter ofinstall-e2e.ymlandruntime-live-e2e.yml.go build ./...+go test ./...gate and the install matrix now run on main-PRs.waiting, never auto-spend API credits.nextandmain.Evidence
go test ./...1249/1249;internal/releaseworkflow_exec_guard green (no structural guard reds on the edit).buildalready runs on a main-PR.Review guidance
On
main's branch protection, mark onlyoffline/install/docsas required checks — never the live lanes (they wait on environment approval by design).ea