fix(dispatch): make launcher-command test hermetic to ambient SPACEDOCK_BIN#340
Merged
Merged
Conversation
…CK_BIN The runLauncherCommand helper inherited the ambient environment via os.Environ(), so the unset subcase leaked any SPACEDOCK_BIN set by a spacedock claude/codex session and ran the real binary instead of the PATH fallback stub. Strip SPACEDOCK_BIN from the base env so each subcase fully controls the value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the dispatch launcher-command test hermetic to an ambient
SPACEDOCK_BIN, so it passes under aspacedock claude/codexsession (which exports one) as well as in CI.What changed
SPACEDOCK_BINfrom the inherited environment inrunLauncherCommandso each subcase fully controls the value it sets.Evidence
/unsetsubcase failing underSPACEDOCK_BIN=$(command -v go); passes after the fix.go test ./...→ 1247 passed, 0 failed — both withSPACEDOCK_BINexported and underenv -u SPACEDOCK_BIN.Test-only change; production
launcher_command.gois untouched.