Launch-banner UX — first-officer framing, status-command overload, multi-workflow limbo#338
Merged
Merged
Conversation
Rewrite launchBanner to the captain-approved wording: line 1
`launching {host} as your first officer` (never the flipped
`first officer launching`), line 3 `{host} is your first officer —
ask it for the queue and next steps.` (drops both self-serve
`spacedock status` instructions).
detectedWorkflow now returns a (label, value) pair so the line-2 label
agrees with its content: single/none use `Workflow:`, multi uses
`Workflows:`. The multi branch lists the discovered workflow paths
space-joined in discovery order (`Workflows: docs/dev docs/user-testing`)
instead of a count + pick instruction; the none branch drops the
`(launching anyway)` parenthetical.
runPi now emits the same 3-line banner before launch, closing the pi
no-orientation gap (AC-7). Default cli.Version is the `dev` sentinel so
an unstamped go build/install binary does not impersonate a release
(AC-6); a stamped release still overwrites it via the ldflags path.
Tests over rendered banner output: AC-5 byte-exact golden on the
single-workflow path; AC-1/2/3/4/7 presence/absence; AC-6 a property +
`^\d+\.\d+\.\d+$` non-match over the package-default Version. Existing
launch_banner_test.go expected strings updated to the AFTER wording.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-launch banner flipped the first-officer metaphor and overloaded
spacedock status; now it reads with one stable framing across every host and workflow shape.What changed
launching {host} as your first officer(no metaphor flip).ask it for the queue and next steps(drop self-servespacedock status).runPi, closing pi's no-orientation gap.Versiontodevso a dev build cannot impersonate a release.Evidence
go test ./internal/cli/→ 272/272 passed; AC-5 byte-exact golden and AC-6Versionregex hold.Version, dropped pi banner) each caught RED; no material findings.cm