Gate the release/flip on the live e2e suite (today it's PR-only behind manual env approval)#337
Merged
Merged
Conversation
Add an `e2e-gate` job to release.yml that goreleaser `needs:`. It resolves the tagged commit SHA (`git rev-list -1 "$GITHUB_REF_NAME"`) and asks the new `spacedock-release e2e-gate` subcommand whether a `conclusion: success` Runtime Live E2E run exists for that exact commit — a green run means every live lane was approved and passed (a parked/offline-only run is never `success`). No matching run blocks the cut. `SPACEDOCK_E2E_GATE_WAIVER` (a non-empty reason) is the auditable captain-waiver escape hatch, recorded to $GITHUB_STEP_SUMMARY. The SHA-match decision is a pure `EvaluateE2EGate` predicate in internal/release, mirroring the journey-costs subcommand shape. AC-1 is proved by a workflow-guard test parsing the real release.yml (needs-edge + SHA-bound gate step) with adversarial dropped-edge / weakened-SHA variants the guard rejects; AC-2/AC-3 by predicate + subcommand unit tests over fixture run-list JSON for the pass/block(parked,wrong-SHA,empty)/waiver cases. No live run at implementation time. M2 co-edit (same change): the `needs: e2e-gate` edge changes the goreleaser job header, so the four byte-literal `goreleaser:`/`runs-on: macos-latest` anchors in journey_workflow_test.go track the new header and the no-`needs` assertion now requires goreleaser needs exactly ["e2e-gate"] (never journey-ledger). `go test ./internal/release/` is green over the whole package (AC-4). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
clkao
added a commit
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release/tag path ran no end-to-end check; now a
v*cut cannot publish unless the live e2e suite passed green for that exact commit.What changed
e2e-gatejob torelease.ymlthat goreleaser nowneeds:.EvaluateE2EGatepredicate andspacedock-release e2e-gatesubcommand.SPACEDOCK_E2E_GATE_WAIVERescape hatch for emergency cuts.journey_workflow_test.goanchors to the new header; keep ledger separation.Evidence
go test ./internal/release/ ./cmd/spacedock-release/→ 80/80 passed; the wholeinternal/releasepackage is green.Review guidance
journey_workflow_test.go: theneeds: e2e-gateedge re-aligns four byte-literal anchors; goreleaser must need exactly[e2e-gate], never the ledger.nzb