chore: harden Drake demo build readiness by sp80808 · Pull Request #72 · sp80808/XPadInput

sp80808 · 2026-09-04T15:11:03Z

Why

Prepare the current XPI mainline for the Drake Music accessibility/R&D demo without broadening feature scope.

Changes

mark XPadPracticeTests as @MainActor so the standard XCTest suite matches ProgressTracker isolation under current Swift toolchains;
stop CI packaging a stale hard-coded 0.0.02 artifact and let scripts/package-macos.sh use its current alpha version;
upload version-agnostic XPadInput DMG/ZIP paths so future alpha bumps do not silently drift from CI packaging.

Scope

Bounded test/release hygiene only. No product behavior changes.

Validation target

swift build, standard swift test, the exhaustive XPadTests runner, and macOS packaging should all be inspected before merge.

Note

Low Risk
Bounded CI and test-only changes with no intentional product behavior changes; CI will fail on regressions that were previously ignored.

Overview
CI now treats XCTest failures as real failures by dropping || true on swift test --enable-code-coverage, so the standard suite must pass before merge.

macOS alpha packaging and uploads no longer pin 0.0.02: CI invokes scripts/package-macos.sh without a fixed version (script default / env) and uploads dist/XPadInput-*.dmg and *.zip so artifact paths stay in sync when the alpha version bumps.

Test hygiene for current Swift toolchains: XPadPracticeTests is marked @MainActor to match ProgressTracker isolation; MIDI loopback assertions compare against UInt32 bitfields; and the arcade-fret minor-scale case uses rightTriggerValue and .naturalMinor so the expected Fmaj7 degree lines up with the diatonic set under test.

^{Reviewed by Cursor Bugbot for commit e7fd12a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by Sourcery

Harden test validation and macOS alpha artifact packaging for reliable CI readiness.

Enhancements:

Align XCTest concurrency annotations and MIDI assertions with current Swift type and isolation requirements.
Correct the arcade fret engine test inputs and natural-minor scale expectation.

CI:

Make XCTest failures block CI and use version-independent macOS alpha packaging and artifact paths.

Tests:

Update test coverage for corrected arcade fret behavior and stricter MIDI value comparisons.

chatgpt-codex-connector · 2026-09-04T15:11:09Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

qodo-code-review · 2026-09-04T15:11:09Z

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

sourcery-ai · 2026-09-04T15:11:14Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Hardens test and release hygiene for the Drake demo by matching XCTest actor isolation and making CI package and upload the script-selected alpha version without changing product behavior.

Sequence diagram for CI macOS alpha packaging

sequenceDiagram
    participant CI as GitHub Actions CI
    participant PackageScript as package-macos.sh
    participant Dist as dist artifacts
    participant Upload as upload-artifact

    CI->>PackageScript: package-macos.sh
    PackageScript->>Dist: create XPadInput-alpha.dmg and XPadInput-alpha.zip
    CI->>Upload: upload dist/XPadInput-*.dmg and dist/XPadInput-*.zip
    Upload->>CI: fail if no matching files

File-Level Changes

Change	Details	Files
Align the practice test suite with main-actor isolation requirements.	Annotate the XCTest case with `@MainActor` to match `ProgressTracker` isolation and current Swift toolchains.	`Tests/XPadPracticeTests/XPadPracticeTests.swift`
Make macOS alpha packaging and artifact collection follow the package script’s current version.	Remove the hard-coded package version argument from CI. Replace version-specific artifact paths with wildcard DMG and ZIP paths while retaining checksum upload and missing-file failure behavior.	`.github/workflows/ci.yml`

Possibly linked issues

#unknown: PR directly refines the issue’s macOS CI packaging and Swift test validation requirements.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

cursor · 2026-09-04T15:11:14Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_6459aa6e-c6d3-452b-9c2e-4469326f647e)

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

cursor · 2026-09-04T15:16:58Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_69a771b6-6900-4136-8488-4893c152a9d7)

cursor · 2026-09-04T15:22:54Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ee9d3b5d-edf9-4e03-b2d6-bd94f4ba28ef)

Sourcery withdrew this approval because the latest commits introduced blocking findings.

cursor · 2026-09-04T15:26:59Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fcbd2e87-994b-4289-98f7-8bd1fbe3a24e)

sourcery-ai

Sourcery assessment

Approved.

sp80808 · 2026-09-28T12:48:23Z

Merge hold: the workflow change is doing its job. CI reaches swift test --enable-code-coverage and now fails on 9 XCTest failures that were previously masked by || true (for example XPadPracticeTests.testLessonMastery, where mastery remains notStarted). Build/checkout/cache steps are green; packaging is skipped only because tests fail. Keep the stricter gate and fix/triage the failing tests before merging this demo-readiness PR.

sp80808 added 2 commits September 4, 2026 16:10

fix(tests): isolate practice XCTest suite to MainActor

06eea2a

fix(ci): package current alpha version instead of stale 0.0.02

3d8b90e

sourcery-ai Bot previously approved these changes Sep 4, 2026

View reviewed changes

fix(tests): compare CoreMIDI UMP fields with matching UInt32 types

e681b96

ci: make XCTest failures block demo build

ce089a9

fix(tests): use natural-minor scale and degree-VI lane in arcade test

e7fd12a

sourcery-ai Bot approved these changes Sep 4, 2026

View reviewed changes

Conversation

sp80808 commented Sep 4, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Changes

Scope

Validation target

Summary by Sourcery

Uh oh!

chatgpt-codex-connector Bot commented Sep 4, 2026

Uh oh!

qodo-code-review Bot commented Sep 4, 2026

Uh oh!

sourcery-ai Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for CI macOS alpha packaging

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

cursor Bot commented Sep 4, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

cursor Bot commented Sep 4, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

cursor Bot commented Sep 4, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

cursor Bot commented Sep 4, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

sp80808 commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sp80808 commented Sep 4, 2026 •

edited by cursor Bot

Loading

sourcery-ai Bot commented Sep 4, 2026 •

edited

Loading