Repository navigation
Conversation
getLessonMastery(for:) is MainActor-isolated; calling it from a nonisolated XCTest method fails to compile under Swift 6 strict concurrency (Tests/XPadPracticeTests.swift:118). Annotating the test class @mainactor is the standard XCTest migration.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMarks XPadPracticeTests as @mainactor so its tests can safely access the main-actor-isolated ProgressTracker under Swift 6 strict concurrency; verification confirms the file’s reported errors are resolved, while unrelated CoreMIDILoopbackTests failures remain out of scope. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under latest-stable Xcode / Swift 6.2:
ProgressTrackeris main-actor-isolated (@MainActor public final class), butXPadPracticeTestscalls it from nonisolated XCTest methods — rejected by Swift 6 isolation checking.Fix
Annotate the test class
@MainActor— the standard XCTest migration for testing MainActor-isolated code (XCTestCase supports async/main-actor test methods natively).Verification
Verified on macOS 15 / Xcode latest-stable (public CI run): with this patch, all
XPadPracticeTestserrors are gone.Scope note:
swift teststill surfaces separate pre-existing type-conversion errors inTests/XPadMIDITests/CoreMIDILoopbackTests.swift(~258) — unrelated to this file, reported separately so each fix stays reviewable.Summary by Sourcery
Enable XPadPracticeTests to compile under Swift 6 strict concurrency by aligning the test class with the main-actor isolation of the code it exercises.
Bug Fixes:
Tests: