Repository navigation
fix(ui): resolve 'ambiguous use of cos' build failure under Swift 6.2 / latest Xcode - #69
Merged
Merged
Conversation
HarmonicWheelView.swift:201-202 fails to compile with latest-stable Xcode
('ambiguous use of cos'). Pin the trig calls to the unambiguous Double
overload and wrap back to CGFloat; math unchanged.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the harmonic wheel’s trail-dot coordinate calculations to explicitly use Double-based cos/sin overloads, resolving the latest Xcode/Swift 6.2 build failure without changing the math or visual behavior. Verification confirms zero errors in Sources/; an unrelated pre-existing test isolation error remains. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maincurrently fails to compile with latest-stable Xcode (Swift 6.2):Swift 6.2 tightened overload resolution;
cos(CGFloat(angle))now matches multiple Foundation/Darwin declarations.Fix
Pin both trig calls to the unambiguous
Doubleoverload and convert back:Math is unchanged (
angleis already numeric).Verification
Built on macOS 15 / Xcode latest-stable via a clean CI run (public workflow run):
swift buildreports zero errors in Sources/.Tests/XPadPracticeTests.swift:118), filed separately so this PR stays minimal.Happy to adjust if you'd prefer
Foundation.cosqualification or a different resolution style.Summary by Sourcery
Bug Fixes: