fix media controls F8 hotkey of play_or_pause - #417
Open
9tong wants to merge 4 commits into
Open
Conversation
Root cause: - Remote media commands were registered from SwiftUI window tasks, leaving an initialization window where F8 was not routed to Kaset. - Kaset released its native Now Playing claim during music loading and buffering, allowing macOS to route the media key to another app. - The app-wide playback state was only synchronized while Kaset still owned its fallback metadata. Fix: - Register remote media commands and YouTube routing during app initialization. - Keep a native playing claim during music loading and buffering until WebKit publishes the rich Now Playing card. - Synchronize MPNowPlayingInfoCenter playback state without replacing WebKit metadata. - Add regression coverage for loading and buffering ownership.
Author
|
also add keeping F8 media controls active across audio route changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
Fix: