Skip to content

fix: Filter toggle button & Search field style updated in responsive device#2625

Open
iamibrahimriaz wants to merge 14 commits intosovware:developmentfrom
iamibrahimriaz:improve/filter-btn-placement
Open

fix: Filter toggle button & Search field style updated in responsive device#2625
iamibrahimriaz wants to merge 14 commits intosovware:developmentfrom
iamibrahimriaz:improve/filter-btn-placement

Conversation

@iamibrahimriaz
Copy link
Collaborator

@iamibrahimriaz iamibrahimriaz commented Dec 18, 2025

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

Disabling the Listing header no longer hides the sidebar toggle button in responsive view, since the toggler has been moved outside the header section.

Before: https://prnt.sc/CjtoJuSjP2VW | https://prnt.sc/NYsKsz-wQ4Yf

After: https://prnt.sc/pChmYOLX2l2t , https://prnt.sc/m7EGu-wqusME

Also updated the responsive media breakpoint from 991px to 767px. https://prnt.sc/yxZcHnc5lMSP

Any linked issues

Fixes #

Checklist

@gaa23
Copy link

gaa23 commented Dec 19, 2025

It looks way better inside the header when the header is enabled, when its enabled can it nest nicely with the other icons?

@iamibrahimriaz iamibrahimriaz changed the title Filter toggle button & Search field style updated in responsive device fix: Filter toggle button & Search field style updated in responsive device Dec 22, 2025
@RabbiIslamRony RabbiIslamRony added this to the v8.5.8 milestone Dec 29, 2025
@RabbiIslamRony
Copy link
Member

@iamibrahimriaz Please add a listing shortcode and Gutenberg block on a same page (https://imgur.com/HqTVQhA
). Then set Gutenberg block sidebar to “no sidebar” and enable the filter button (https://imgur.com/Yh2VitR
). The filter button is not working properly conditionally in the Gutenberg block (https://imgur.com/RrsBBK8
).

@iamibrahimriaz
Copy link
Collaborator Author

iamibrahimriaz commented Jan 14, 2026

It looks way better inside the header when the header is enabled, when its enabled can it nest nicely with the other icons?

@gaa23 The filter toggle button should be separate from the header because the header is an individual module.

@Armanul46 Armanul46 modified the milestones: v8.5.8, v8.5.9 Jan 19, 2026
@iamibrahimriaz
Copy link
Collaborator Author

@iamibrahimriaz Please add a listing shortcode and Gutenberg block on a same page (https://imgur.com/HqTVQhA ). Then set Gutenberg block sidebar to “no sidebar” and enable the filter button (https://imgur.com/Yh2VitR ). The filter button is not working properly conditionally in the Gutenberg block (https://imgur.com/RrsBBK8 ).

Fixed

@Armanul46 Armanul46 modified the milestones: v8.5.9, 8.5.10 Jan 28, 2026
@RabbiIslamRony
Copy link
Member

@iamibrahimriaz The header is still visible in the responsive view even when it’s disabled, so it’s not working as described (Guteberg block)

@RabbiIslamRony
Copy link
Member

RabbiIslamRony commented Feb 15, 2026

@iamibrahimriaz When the sidebar is set to popup filter and the filter button is enabled, it doesn’t appear on the frontend (likely already present in the development branch — adjustment needed to complete this PR). https://prnt.sc/-E4KZKBJKsQs

@iamibrahimriaz
Copy link
Collaborator Author

@RabbiIslamRony its need to fix on another PR. This PR is only for sidebar filter toggle button in responsive device. It will be great, if you create an issue in details.

@RabbiIslamRony
Copy link
Member

@iamibrahimriaz During investigation, the previous responsive breakpoint was 991px. After fixing the filter toggler button, it is now 767px — please note that the responsive media breakpoint has been changed.

@iamibrahimriaz
Copy link
Collaborator Author

@RabbiIslamRony Breakpoint was intentionally changed after discussion with the CPO.

@Armanul46 Armanul46 modified the milestones: 8.5.10, v8.5.11 Feb 16, 2026
@RabbiIslamRony
Copy link
Member

@iamibrahimriaz Clicking “Select” in the search area causes the sidebar to hide automatically. https://prnt.sc/XR5LLqejsgcy

@iamibrahimriaz
Copy link
Collaborator Author

@iamibrahimriaz Clicking “Select” in the search area causes the sidebar to hide automatically. https://prnt.sc/XR5LLqejsgcy

It's not related to this PR. Need another PR to fix this issue.

@Armanul46 Armanul46 modified the milestones: v8.6, v8.6.1 Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments