-
-
Notifications
You must be signed in to change notification settings - Fork 787
Add Rocky Linux and AlmaLinux support #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
|
@copilot fix the markdown error |
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
|
@copilot add those platforms to ci.yml |
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Added in commit e66e072:
Note: Rocky Linux is intentionally excluded from installation-script tests (as configured in kitchen.yml line 35), matching the AlmaLinux exclusion pattern. |
damacus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do not update changelog.md we are using release-plesse, update your copilot instructions for this new rule
…se-please Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Done in commit c2ebdfd:
|
|
@copilot ignore multiple consecutive blank lines in markdown |
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Slowest examplesTop 10 slowest examples (2.13 seconds, 26.48% of total time)
|
|
@copilot ignore md004 markdown error |
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Slowest examplesTop 10 slowest examples (1.9 seconds, 24.82% of total time)
|
Changes Made
This PR adds support for Rocky Linux and AlmaLinux distributions to the Docker cookbook.
Code Changes
resources/installation_package.rb: Added explicit platform detection for Rocky Linux and AlmaLinux to map them to CentOS repositories (Docker provides CentOS repos that work with these RHEL-compatible distributions)spec/docker_test/installation_package_spec.rb: Added comprehensive unit tests for Rocky Linux 8/9 and AlmaLinux 8/9metadata.rb: Added Rocky Linux and AlmaLinux to supported platformsREADME.md: Updated Platform Support section to list Rocky Linux 8/9 and AlmaLinux 8/9.github/workflows/ci.yml: Added Rocky Linux 8/9/10 to integration test matrix and Rocky Linux 8/9 to smoke test matrix.github/copilot-instructions.md: Updated instructions to reflect that this repository uses release-please for automatic changelog generation (do not manually update CHANGELOG.md).markdownlint-cli2.yamland.mdlrc: Disabled MD004 (ul-style) and MD012 (no-multiple-blanks) rules to allow flexible markdown formattingTechnical Details
Rocky Linux and AlmaLinux are binary-compatible successors to CentOS. The implementation adds explicit platform detection that maps these platforms to use 'centos' in the Docker repository URL:
This ensures compatibility since Docker doesn't provide Rocky/Alma-specific repositories.
Testing
Rocky Linux is intentionally excluded from installation-script tests (as configured in kitchen.yml), matching the AlmaLinux exclusion pattern.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.