Simplify mcp_make_error_resource_not_found#2468
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Simplifies 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| SOURCEMETA_CORE_MCP_EXPORT | ||
| auto mcp_make_error_resource_not_found(const sourcemeta::core::JSON &identifier, | ||
| const JSON::StringView uri) | ||
| auto mcp_make_error_resource_not_found(const sourcemeta::core::JSON &identifier) |
There was a problem hiding this comment.
src/core/mcp/include/sourcemeta/core/mcp.h:329 — Changing mcp_make_error_resource_not_found to drop the uri parameter (and thereby removing error.data from the envelope) is a public API + wire-format change that could break downstream callers expecting the URI to be present somewhere in the error response.
Severity: medium
Other Locations
src/core/mcp/mcp.cc:181
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: ad90fb4 | Previous: fe6cf2d | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1713789109964834 ns/iter |
2.010835848003498 ns/iter |
1.08 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.8515684588303554 ns/iter |
1.7110554161518983 ns/iter |
1.08 |
Regex_Period_Asterisk |
1.9724442761330994 ns/iter |
1.7764185332258684 ns/iter |
1.11 |
Regex_Group_Period_Asterisk_Group |
1.743302291577518 ns/iter |
1.7224558291401961 ns/iter |
1.01 |
Regex_Period_Plus |
2.142499971631113 ns/iter |
2.0000323549029377 ns/iter |
1.07 |
Regex_Period |
2.130762942823233 ns/iter |
2.0278505311681845 ns/iter |
1.05 |
Regex_Caret_Period_Plus_Dollar |
2.1416073228206556 ns/iter |
2.003155724355338 ns/iter |
1.07 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.2379906682738744 ns/iter |
2.0256757330544573 ns/iter |
1.10 |
Regex_Caret_Period_Asterisk_Dollar |
1.8935203926541206 ns/iter |
1.6700846350102652 ns/iter |
1.13 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.029362628398543 ns/iter |
1.693423415362482 ns/iter |
1.20 |
Regex_Caret_X_Hyphen |
6.521882987269937 ns/iter |
6.184966402656459 ns/iter |
1.05 |
Regex_Period_Md_Dollar |
16.98317489217671 ns/iter |
17.028282894599652 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
4.754475341653326 ns/iter |
4.4100078702706895 ns/iter |
1.08 |
Regex_Caret_Period_Range_Dollar |
2.093909276778295 ns/iter |
2.1319075410833275 ns/iter |
0.98 |
Regex_Nested_Backtrack |
26.569038609562163 ns/iter |
25.12198989077627 ns/iter |
1.06 |
JSON_Array_Of_Objects_Unique |
494.5559726827269 ns/iter |
427.99667028144665 ns/iter |
1.16 |
JSON_Parse_1 |
5783.85698564232 ns/iter |
5265.381787676554 ns/iter |
1.10 |
JSON_Parse_Real |
9082.056175165762 ns/iter |
8163.83133157448 ns/iter |
1.11 |
JSON_Parse_Decimal |
9085.083640221877 ns/iter |
9698.71671935695 ns/iter |
0.94 |
JSON_Parse_Schema_ISO_Language |
3421909.889952028 ns/iter |
3810364.473118229 ns/iter |
0.90 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.97655735634495 ns/iter |
66.87465474823517 ns/iter |
0.94 |
JSON_Equality_Helm_Chart_Lock |
144.82433572357934 ns/iter |
148.8027031573935 ns/iter |
0.97 |
JSON_Divisible_By_Decimal |
188.92437448689054 ns/iter |
196.7705052041123 ns/iter |
0.96 |
JSON_String_Equal/10 |
7.208067110543439 ns/iter |
7.757683364338713 ns/iter |
0.93 |
JSON_String_Equal/100 |
6.711222628964345 ns/iter |
8.775277288935651 ns/iter |
0.76 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.8805774750056039 ns/iter |
1.4043410961283551 ns/iter |
0.63 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.6517367805033656 ns/iter |
3.7506904481041157 ns/iter |
0.97 |
JSON_String_Fast_Hash/10 |
2.693106621675238 ns/iter |
2.7459323563476854 ns/iter |
0.98 |
JSON_String_Fast_Hash/100 |
2.127442606938741 ns/iter |
2.644733335893519 ns/iter |
0.80 |
JSON_String_Key_Hash/10 |
1.5071924477212244 ns/iter |
1.7330024032273486 ns/iter |
0.87 |
JSON_String_Key_Hash/100 |
2.559791976344036 ns/iter |
2.5758903691593074 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Same_Length |
2.492200366396285 ns/iter |
2.7037465764189355 ns/iter |
0.92 |
JSON_Object_Defines_Miss_Too_Small |
2.5030582821991962 ns/iter |
2.800087392151184 ns/iter |
0.89 |
JSON_Object_Defines_Miss_Too_Large |
2.605641127417474 ns/iter |
2.8512932869111807 ns/iter |
0.91 |
Pointer_Object_Traverse |
16.11543916712801 ns/iter |
16.95105513541912 ns/iter |
0.95 |
Pointer_Object_Try_Traverse |
24.541054644867764 ns/iter |
27.226019684687355 ns/iter |
0.90 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
173.98872489711346 ns/iter |
183.48268639958624 ns/iter |
0.95 |
Pointer_Walker_Schema_ISO_Language |
5074203.335999755 ns/iter |
7252474.009901291 ns/iter |
0.70 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1235632.713740468 ns/iter |
1625969.5326884722 ns/iter |
0.76 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1444669.9461697694 ns/iter |
1676212.8378374923 ns/iter |
0.86 |
Pointer_Position_Tracker_Get_Deeply_Nested |
357.333739540945 ns/iter |
388.0661191402859 ns/iter |
0.92 |
URITemplateRouter_Create |
26572.203237410235 ns/iter |
28855.628612944038 ns/iter |
0.92 |
URITemplateRouter_Match |
172.17391845192347 ns/iter |
190.559486205637 ns/iter |
0.90 |
URITemplateRouter_Match_BasePath |
197.64638970376564 ns/iter |
220.3548792758473 ns/iter |
0.90 |
URITemplateRouterView_Restore |
10855.017177390942 ns/iter |
11513.873336189561 ns/iter |
0.94 |
URITemplateRouterView_Match |
149.86621777721246 ns/iter |
147.8216975709563 ns/iter |
1.01 |
URITemplateRouterView_Match_BasePath |
155.07745567619665 ns/iter |
154.62870951205232 ns/iter |
1.00 |
URITemplateRouterView_Arguments |
442.9590014461979 ns/iter |
428.59548714915513 ns/iter |
1.03 |
JSONL_Parse_Large |
16097707.499999387 ns/iter |
13341380.388889471 ns/iter |
1.21 |
JSONL_Parse_Large_GZIP |
15479732.954545967 ns/iter |
15510367.187497802 ns/iter |
1.00 |
HTML_Build_Table_100000 |
67798597.22221696 ns/iter |
81925208.33341001 ns/iter |
0.83 |
HTML_Render_Table_100000 |
4996918.750000289 ns/iter |
4457718.623452371 ns/iter |
1.12 |
GZIP_Compress_ISO_Language_Set_3_Locations |
31848672.363635574 ns/iter |
30338094.21741234 ns/iter |
1.05 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
5861253.634920544 ns/iter |
5344925.150442964 ns/iter |
1.10 |
GZIP_Compress_ISO_Language_Set_3_Schema |
1724961.0983981516 ns/iter |
1549140.2489366939 ns/iter |
1.11 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
373990.3739456581 ns/iter |
284083.6103949304 ns/iter |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: ad90fb4 | Previous: fe6cf2d | Ratio |
|---|---|---|---|
GZIP_Compress_ISO_Language_Set_3_Locations |
40032366.47058791 ns/iter |
40041539.117647275 ns/iter |
1.00 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4741132.094595188 ns/iter |
4605534.526666588 ns/iter |
1.03 |
GZIP_Compress_ISO_Language_Set_3_Schema |
2307148.1788078086 ns/iter |
2301977.6973685534 ns/iter |
1.00 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
324270.1484374999 ns/iter |
293980.9475638042 ns/iter |
1.10 |
HTML_Build_Table_100000 |
71885808.39999759 ns/iter |
71440075.99999896 ns/iter |
1.01 |
HTML_Render_Table_100000 |
2066910.9797685938 ns/iter |
1975591.8142855729 ns/iter |
1.05 |
JSONL_Parse_Large |
14789111.85106523 ns/iter |
15126402.413043054 ns/iter |
0.98 |
JSONL_Parse_Large_GZIP |
16113066.674419379 ns/iter |
16386498.627906444 ns/iter |
0.98 |
URITemplateRouter_Create |
29937.60679838579 ns/iter |
29467.331319487286 ns/iter |
1.02 |
URITemplateRouter_Match |
164.02378189849952 ns/iter |
158.33991055403771 ns/iter |
1.04 |
URITemplateRouter_Match_BasePath |
195.43011297006223 ns/iter |
188.23309027181415 ns/iter |
1.04 |
URITemplateRouterView_Restore |
8732.350482353546 ns/iter |
8697.531089490003 ns/iter |
1.00 |
URITemplateRouterView_Match |
128.56622799850015 ns/iter |
124.64464974137634 ns/iter |
1.03 |
URITemplateRouterView_Match_BasePath |
144.17973117285968 ns/iter |
143.8431469566393 ns/iter |
1.00 |
URITemplateRouterView_Arguments |
453.3546658415238 ns/iter |
458.34000529303717 ns/iter |
0.99 |
Pointer_Object_Traverse |
34.2970777267439 ns/iter |
34.11538536194793 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
22.124372524668065 ns/iter |
21.98696670100176 ns/iter |
1.01 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
136.0557476014177 ns/iter |
136.08483082777326 ns/iter |
1.00 |
Pointer_Walker_Schema_ISO_Language |
4028780.8684207737 ns/iter |
3635916.3928569634 ns/iter |
1.11 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1875312.3512062947 ns/iter |
1861357.4031830325 ns/iter |
1.01 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1858123.3763158205 ns/iter |
1883748.8894878835 ns/iter |
0.99 |
Pointer_Position_Tracker_Get_Deeply_Nested |
569.5765459447477 ns/iter |
572.8589182353895 ns/iter |
0.99 |
JSON_Array_Of_Objects_Unique |
413.9569002491369 ns/iter |
419.95133613048284 ns/iter |
0.99 |
JSON_Parse_1 |
9720.941263497944 ns/iter |
9789.565024492082 ns/iter |
0.99 |
JSON_Parse_Real |
13204.205171959766 ns/iter |
13137.60996912794 ns/iter |
1.01 |
JSON_Parse_Decimal |
17495.066589695158 ns/iter |
17057.58143893284 ns/iter |
1.03 |
JSON_Parse_Schema_ISO_Language |
5734123.866667081 ns/iter |
5774721.804878174 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.343955035346305 ns/iter |
61.30852823091589 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
183.0943888295449 ns/iter |
172.31138431390164 ns/iter |
1.06 |
JSON_Divisible_By_Decimal |
230.24103028462835 ns/iter |
231.82153448512548 ns/iter |
0.99 |
JSON_String_Equal/10 |
6.111173734181578 ns/iter |
6.114412830850055 ns/iter |
1.00 |
JSON_String_Equal/100 |
6.882269102442472 ns/iter |
6.966122002438372 ns/iter |
0.99 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.7138491484735667 ns/iter |
0.7111757497844186 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
21.937438731390685 ns/iter |
21.951220280982454 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
1.7615419117749258 ns/iter |
1.7584711619715003 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
1.7592624291822458 ns/iter |
1.7587519360645085 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.0840719239712318 ns/iter |
1.0850968900875846 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
14.754917029195585 ns/iter |
14.767415853664732 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.8677524684048037 ns/iter |
3.8886116862600515 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Too_Small |
3.5166301812092864 ns/iter |
3.5169091264663384 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
4.22077539281051 ns/iter |
4.219610344057994 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
0.7030034116711136 ns/iter |
0.7038214032873846 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
0.7033580555030481 ns/iter |
0.7042668836261515 ns/iter |
1.00 |
Regex_Period_Asterisk |
1.0562097794038918 ns/iter |
1.055477932419015 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
1.0756492741095671 ns/iter |
1.0552310607384283 ns/iter |
1.02 |
Regex_Period_Plus |
0.7048445893029095 ns/iter |
0.7032150387981557 ns/iter |
1.00 |
Regex_Period |
0.7048095822953907 ns/iter |
0.703289696699089 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
1.0553107372338628 ns/iter |
1.0564138638199936 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.0614135027217455 ns/iter |
1.0576392341948366 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
0.7034770415872242 ns/iter |
0.7034214714247459 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
0.7064578014937717 ns/iter |
0.705503404640222 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
3.5181143919817126 ns/iter |
3.8698630002216294 ns/iter |
0.91 |
Regex_Period_Md_Dollar |
34.322657101896446 ns/iter |
33.67427796527835 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
4.570883705543558 ns/iter |
4.588304921895854 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
0.8395366990679738 ns/iter |
0.8472261272338164 ns/iter |
0.99 |
Regex_Nested_Backtrack |
46.808893721602416 ns/iter |
38.70772641010307 ns/iter |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: ad90fb4 | Previous: fe6cf2d | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.19079496072706 ns/iter |
2.2198003208633903 ns/iter |
0.99 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.188163808931399 ns/iter |
2.198458350128735 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.179198966658027 ns/iter |
2.19241095280019 ns/iter |
0.99 |
Regex_Group_Period_Asterisk_Group |
2.1779255065035845 ns/iter |
2.1996050096327884 ns/iter |
0.99 |
Regex_Period_Plus |
2.800754387495078 ns/iter |
2.854730033648928 ns/iter |
0.98 |
Regex_Period |
2.8047827531976193 ns/iter |
2.8017253081883178 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
2.489676706925086 ns/iter |
2.488938806721525 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.491769827875369 ns/iter |
2.488702213374691 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.423537922245445 ns/iter |
3.4306951171617124 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.422290311161948 ns/iter |
3.426044396606113 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
6.542129527504607 ns/iter |
6.5377451740812 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
27.98699146360316 ns/iter |
27.95253783293417 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.230322338527218 ns/iter |
5.911218873540801 ns/iter |
1.05 |
Regex_Caret_Period_Range_Dollar |
2.802746824533113 ns/iter |
2.801286242958691 ns/iter |
1.00 |
Regex_Nested_Backtrack |
37.33139365027058 ns/iter |
37.00628813318486 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
472.064748526786 ns/iter |
493.1990916423395 ns/iter |
0.96 |
JSON_Parse_1 |
6830.467079512083 ns/iter |
6883.968445259204 ns/iter |
0.99 |
JSON_Parse_Real |
11852.553566302275 ns/iter |
12285.614182630668 ns/iter |
0.96 |
JSON_Parse_Decimal |
11244.267082645436 ns/iter |
11672.939662495113 ns/iter |
0.96 |
JSON_Parse_Schema_ISO_Language |
3835551.6318683387 ns/iter |
3847256.6229508426 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
73.86982300629228 ns/iter |
66.33043432490602 ns/iter |
1.11 |
JSON_Equality_Helm_Chart_Lock |
178.37198319888353 ns/iter |
179.80854714302092 ns/iter |
0.99 |
JSON_Divisible_By_Decimal |
253.43773273893513 ns/iter |
254.46917525439414 ns/iter |
1.00 |
JSON_String_Equal/10 |
6.544333167552731 ns/iter |
6.546957600664495 ns/iter |
1.00 |
JSON_String_Equal/100 |
7.170022095586232 ns/iter |
7.202064605366773 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9395680991023078 ns/iter |
0.9396139502637549 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.92663376001616 ns/iter |
10.655258581033351 ns/iter |
1.40 |
JSON_String_Fast_Hash/10 |
3.1122820102530877 ns/iter |
3.1188048087952156 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.1125336190948154 ns/iter |
3.1198627608367344 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.730492735308915 ns/iter |
2.1822113288100478 ns/iter |
1.25 |
JSON_String_Key_Hash/100 |
9.0224337505607 ns/iter |
6.536700322475011 ns/iter |
1.38 |
JSON_Object_Defines_Miss_Same_Length |
2.6356128528917515 ns/iter |
2.6996137559262983 ns/iter |
0.98 |
JSON_Object_Defines_Miss_Too_Small |
2.7677356064837872 ns/iter |
2.7182877033237234 ns/iter |
1.02 |
JSON_Object_Defines_Miss_Too_Large |
3.7604525346739037 ns/iter |
3.73996472279293 ns/iter |
1.01 |
Pointer_Object_Traverse |
25.359630288451168 ns/iter |
25.844070403919893 ns/iter |
0.98 |
Pointer_Object_Try_Traverse |
28.29330108126941 ns/iter |
28.453496964490558 ns/iter |
0.99 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
220.72676469082305 ns/iter |
159.38505647582804 ns/iter |
1.38 |
Pointer_Walker_Schema_ISO_Language |
3003507.047209449 ns/iter |
3039739.1739128307 ns/iter |
0.99 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1488715.0676530015 ns/iter |
1498890.0085289618 ns/iter |
0.99 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1829418.5287956789 ns/iter |
1827065.2829131973 ns/iter |
1.00 |
Pointer_Position_Tracker_Get_Deeply_Nested |
639.6848362131213 ns/iter |
683.9722494663005 ns/iter |
0.94 |
URITemplateRouter_Create |
31513.34776026235 ns/iter |
31722.43273169462 ns/iter |
0.99 |
URITemplateRouter_Match |
170.01114109803095 ns/iter |
171.9222357503655 ns/iter |
0.99 |
URITemplateRouter_Match_BasePath |
195.3929805841296 ns/iter |
196.32056042959192 ns/iter |
1.00 |
URITemplateRouterView_Restore |
7847.624441923514 ns/iter |
7758.819577353205 ns/iter |
1.01 |
URITemplateRouterView_Match |
142.81295572263576 ns/iter |
143.35059621030373 ns/iter |
1.00 |
URITemplateRouterView_Match_BasePath |
161.4913233814958 ns/iter |
161.36200172850994 ns/iter |
1.00 |
URITemplateRouterView_Arguments |
447.51887639266994 ns/iter |
436.18736205292555 ns/iter |
1.03 |
JSONL_Parse_Large |
11885065.338982698 ns/iter |
11789167.47457637 ns/iter |
1.01 |
JSONL_Parse_Large_GZIP |
13080134.452833727 ns/iter |
13061004.722222455 ns/iter |
1.00 |
HTML_Build_Table_100000 |
68039433.45454916 ns/iter |
71758292.90908743 ns/iter |
0.95 |
HTML_Render_Table_100000 |
5341307.692307195 ns/iter |
5186473.073529348 ns/iter |
1.03 |
GZIP_Compress_ISO_Language_Set_3_Locations |
33842373.33333269 ns/iter |
33792010.95237607 ns/iter |
1.00 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4662641.054422231 ns/iter |
5073548.710000751 ns/iter |
0.92 |
GZIP_Compress_ISO_Language_Set_3_Schema |
1882487.7499999576 ns/iter |
1881182.1505376853 ns/iter |
1.00 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
380014.26042224374 ns/iter |
380070.4193373255 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
Details
| Benchmark suite | Current: ad90fb4 | Previous: fe6cf2d | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
6.356265178571416 ns/iter |
6.225971000001209 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
6.214463392857234 ns/iter |
6.2797732142862674 ns/iter |
0.99 |
Regex_Period_Asterisk |
6.268710714284761 ns/iter |
5.914817857142144 ns/iter |
1.06 |
Regex_Group_Period_Asterisk_Group |
7.178731249999665 ns/iter |
5.976576785714981 ns/iter |
1.20 |
Regex_Period_Plus |
5.864559999999983 ns/iter |
5.611151999999038 ns/iter |
1.05 |
Regex_Period |
5.723770000001878 ns/iter |
5.452118081574837 ns/iter |
1.05 |
Regex_Caret_Period_Plus_Dollar |
5.4222544642844435 ns/iter |
5.729045535714151 ns/iter |
0.95 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
6.017134000001079 ns/iter |
5.259407621015488 ns/iter |
1.14 |
Regex_Caret_Period_Asterisk_Dollar |
6.502832000001036 ns/iter |
6.219507000000704 ns/iter |
1.05 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
6.414928571426717 ns/iter |
6.117930357143158 ns/iter |
1.05 |
Regex_Caret_X_Hyphen |
10.953395312501613 ns/iter |
9.902397277222768 ns/iter |
1.11 |
Regex_Period_Md_Dollar |
58.051637557701135 ns/iter |
90.44502721228666 ns/iter |
0.64 |
Regex_Caret_Slash_Period_Asterisk |
10.117351562499266 ns/iter |
9.114747767858335 ns/iter |
1.11 |
Regex_Caret_Period_Range_Dollar |
6.861002000000553 ns/iter |
6.526906000001417 ns/iter |
1.05 |
Regex_Nested_Backtrack |
68.44005999998899 ns/iter |
88.85487723213308 ns/iter |
0.77 |
JSON_Array_Of_Objects_Unique |
610.9602999999879 ns/iter |
650.8888000000752 ns/iter |
0.94 |
JSON_Parse_1 |
14707.810714286648 ns/iter |
12914.648214287385 ns/iter |
1.14 |
JSON_Parse_Real |
23049.821873411394 ns/iter |
20103.801288376642 ns/iter |
1.15 |
JSON_Parse_Decimal |
21954.94457662945 ns/iter |
17357.536769218073 ns/iter |
1.26 |
JSON_Parse_Schema_ISO_Language |
8872645.555556523 ns/iter |
8068633.33333341 ns/iter |
1.10 |
JSON_Fast_Hash_Helm_Chart_Lock |
85.94375000000757 ns/iter |
80.32225087846311 ns/iter |
1.07 |
JSON_Equality_Helm_Chart_Lock |
375.69541632577716 ns/iter |
298.04855602133495 ns/iter |
1.26 |
JSON_Divisible_By_Decimal |
349.124910714238 ns/iter |
408.2167540974293 ns/iter |
0.86 |
JSON_String_Equal/10 |
20.807933789234323 ns/iter |
15.361986607140516 ns/iter |
1.35 |
JSON_String_Equal/100 |
21.45641324917494 ns/iter |
23.033800000000326 ns/iter |
0.93 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
3.1570483677165746 ns/iter |
2.558883814108603 ns/iter |
1.23 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
16.634067299326457 ns/iter |
14.30066846294256 ns/iter |
1.16 |
JSON_String_Fast_Hash/10 |
6.26939099999845 ns/iter |
4.654929464286234 ns/iter |
1.35 |
JSON_String_Fast_Hash/100 |
6.164616999999453 ns/iter |
6.218496999999843 ns/iter |
0.99 |
JSON_String_Key_Hash/10 |
6.503601785713694 ns/iter |
6.071008928572042 ns/iter |
1.07 |
JSON_String_Key_Hash/100 |
19.028930165566507 ns/iter |
19.057504049881167 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
4.097326659103314 ns/iter |
4.070796792983468 ns/iter |
1.01 |
JSON_Object_Defines_Miss_Too_Small |
4.105778400188356 ns/iter |
5.585132142856862 ns/iter |
0.74 |
JSON_Object_Defines_Miss_Too_Large |
4.433583750000025 ns/iter |
4.208353190084879 ns/iter |
1.05 |
Pointer_Object_Traverse |
61.63811607143949 ns/iter |
65.92736607142768 ns/iter |
0.93 |
Pointer_Object_Try_Traverse |
71.9024642857034 ns/iter |
78.34411830359552 ns/iter |
0.92 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
198.57533934934804 ns/iter |
178.5425342774114 ns/iter |
1.11 |
Pointer_Walker_Schema_ISO_Language |
12797998.214283878 ns/iter |
14540711.999998167 ns/iter |
0.88 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
2493174.621211879 ns/iter |
2587425.8928563367 ns/iter |
0.96 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
4095797.20670401 ns/iter |
3670630.985915279 ns/iter |
1.12 |
Pointer_Position_Tracker_Get_Deeply_Nested |
636.8774553572161 ns/iter |
726.5830684898559 ns/iter |
0.88 |
URITemplateRouter_Create |
44977.01099715749 ns/iter |
43351.039595008966 ns/iter |
1.04 |
URITemplateRouter_Match |
217.1326644137389 ns/iter |
217.69102481131566 ns/iter |
1.00 |
URITemplateRouter_Match_BasePath |
261.2368571428598 ns/iter |
249.9976785713898 ns/iter |
1.04 |
URITemplateRouterView_Restore |
32750.397321420012 ns/iter |
23475.83571428556 ns/iter |
1.40 |
URITemplateRouterView_Match |
158.4348214285975 ns/iter |
172.55769905518778 ns/iter |
0.92 |
URITemplateRouterView_Match_BasePath |
176.89874622090147 ns/iter |
193.0510886652807 ns/iter |
0.92 |
URITemplateRouterView_Arguments |
551.4080999998896 ns/iter |
546.0669642857852 ns/iter |
1.01 |
JSONL_Parse_Large |
35548784.21052883 ns/iter |
35540905.26315696 ns/iter |
1.00 |
JSONL_Parse_Large_GZIP |
35642384.21052466 ns/iter |
35467264.99999977 ns/iter |
1.00 |
HTML_Build_Table_100000 |
90495800.00000139 ns/iter |
96829542.85715692 ns/iter |
0.93 |
HTML_Render_Table_100000 |
7531189.28571439 ns/iter |
8236934.444446181 ns/iter |
0.91 |
GZIP_Compress_ISO_Language_Set_3_Locations |
40170111.111112624 ns/iter |
43908339.999992065 ns/iter |
0.91 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
9908473.437498344 ns/iter |
11513398.21428467 ns/iter |
0.86 |
GZIP_Compress_ISO_Language_Set_3_Schema |
2289600.3124998286 ns/iter |
2508677.142856998 ns/iter |
0.91 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
659333.8392856854 ns/iter |
685855.5357143002 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com