Fix live runner guard for args-mapping cases#27
Merged
Conversation
Main has the declarative args registry (14c705f) but this guard still required cliCommand, failing every live state case with 'live mode requires a cliCommand'. One-line companion fix that got split from the args commit across concurrent branches (it also exists in live-saml-group-coverage's 828bc65; identical hunk, rebases cleanly). Amp-Thread-ID: https://ampcode.com/threads/T-019eaec8-b78c-7386-b977-d93720ad3219 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's registry uses declarative
argsmappings (14c705f) but the live/performance runner guard still requiredcliCommand, so every live state case failed with 'live mode requires a cliCommand'.One-line companion fix that got separated from the args commit across concurrent working sessions (the same hunk exists in
live-saml-group-coverage's 828bc65 and will rebase cleanly).Verified: local 97/97; live spot-check (full-overwrite-unions, saml-group-live, set-created-after-temp-user) 23/23.