updating html sanitization method to dompurify #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
cc @sqs who wrote this code originally. I see in the biome justification that the html values are not from users, so this may be unnecessary?
Member
|
Your CI failures are super weird, its almost like the github workflow's code changed for npm and is now broken. I think to sort it out we should try bumping the versions of the workflows used. |
Member
|
Gonna see if this fixes the problem #174 |
BolajiOlajide
force-pushed
the
mua/html-sanitization-update
branch
from
d5f20d2 to
265c5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our standard way of sanitizing HTML is using dompurify. we want to stay consistent across our code for that and this update changes over the sanitization to dompurify.