build: drop the link check from the Vercel build; it runs as its own PR check - #1960
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
…PR check The Broken links introduced by this PR job (.github/workflows/check-links.yml) runs dev/check-links.mjs on every pull request, with a baseline so it only reports links the PR introduces, and comments the findings. Running it again without flags in npm run build duplicated that check and made a dead link anywhere in the tree fail the deploy, even one not introduced by the commit. npm run build now runs only the filenames and images checks. npm run check still runs all three. Amp-Thread-ID: https://ampcode.com/threads/T-01a09f23-2ad6-76a8-a697-3da4969f29f9 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #1858,
dev/check-links.mjsruns twice on every PR:.github/workflows/check-links.yml), with--check-anchors --check-self-links --check-external, a baseline ofmainso only links the PR introduces are reported, and a PR comment with the findingsnpm run build, so a dead link anywhere in the tree fails the Vercel deploy, including links the commit did not touchThe PR check is the one that reports and gates; the build copy only duplicates it and can block a deploy without telling anyone which link is at fault (Vercel build logs are team-only, see
dev/report-vercel-build.mjs).What
npm run buildnow runsnode dev/checks.mjs filenames images; the links check is no longer part of the build.npm run checkstill runs all three checks, andnpm run check -- links …is unchanged. Comments indev/checks.mjs,dev/check-links.mjs, andAGENTS.mdupdated to match.Verification
node dev/checks.mjs filenames images→ exit 0, only the filename and image checks runnode dev/checks.mjs→ all three checks run[dead](/no/such/page)indocs/index.mdx: build prefix exits 0,node dev/checks.mjs linksexits 1pnpm buildruns the new prefix, generates mermaid icons, and entersnext build(the Vercel preview on this PR completes the rest)