Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Conductor into java-slang #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Integrate Conductor into java-slang #95
Changes from all commits
18d8da4d637754File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setupJVMreturns a runner function that must be executed to actually start the JVM. Currently, the returned function is discarded, meaning the JVM is never run. Since running the class via the in-memory runner is not yet implemented, this call is dead code and can be removed or commented out to avoid unnecessary instantiation overhead.// setupJVM call removed as it is currently unused dead codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of importing
__EVALUATOR__from./index(which does not export it) and using@ts-expect-error, you can import it directly from./evaluatorwhere it is declared and exported as default. This provides full type safety and avoids compilation/bundling workarounds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
this.entriesarray is declared but never initialized (e.g., to[]), which will cause a runtimeTypeErrorwhenpushis called. Please initializethis.entriesto an empty array. Note that theretrievemethod also has an issue where returning from insideforEachdoes not return from the outer function; consider refactoring it to usefindor afor...ofloop.Uh oh!
There was an error while loading. Please reload this page.