list-aware build/3 for Association.Has#3
Open
MarthinL wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reported misbehaviour of build_assoc in @soundmonster's composite_foreign_keys branch and pull request was identified as resulting from the build/3 function of module Association.Has which was had not yet been updated to handle owner_key and related_key parameters in the list format as occuring when composite foreign keys are being used.
This pull request, at least initially, aims to correct that oversight by providing a composite foreign key ready, i.e. list-aware version of the build function of Association.Has in file association.ex. This trivial branch and pull request comes after two failed attempts at suggesting the change through comments on the original PR.