Skip to content

Format provide and contract-out#81

Open
sorawee wants to merge 1 commit into
masterfrom
contract-out
Open

Format provide and contract-out#81
sorawee wants to merge 1 commit into
masterfrom
contract-out

Conversation

@sorawee
Copy link
Copy Markdown
Owner

@sorawee sorawee commented Oct 31, 2024

According to the discussion in racket/drracket#690 (comment)

(#:dest (or/c #f path-string?)
#:strip-count exact-nonnegative-integer?
#:permissive? any/c
#:filter (path? (or/c path? #f)
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, but unrelated to the change in this PR.

(provide
parse-srv-rr
(contract-out
[struct
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, this needs a fix.

@jackfirth
Copy link
Copy Markdown
Contributor

Looks excellent, modulo the issues you already found. Does it handle the other weird contract-out subforms? Like rename, #:forall, and #:unprotected-submodule.

@sorawee
Copy link
Copy Markdown
Owner Author

sorawee commented Oct 31, 2024

It will when I fix the problem I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants