Follow the system style - #220
Open
geodro wants to merge 1 commit into
Open
Conversation
The color scheme now defaults to "default", so libadwaita follows the org.freedesktop.appearance portal: color scheme, accent color and contrast. GNOME, KDE Plasma and others implement it. A Style menu section (Follow System / Light / Dark) overrides it, stored in a new color-scheme key whose values match AdwColorScheme so they can be passed straight to set_color_scheme. Hardcoded colors become @popover_bg_color, @view_bg_color, @borders and @accent_*. @popover_bg_color is within a shade of the old #353433 in dark, and gives a sane light appearance. The focused tile is tinted with the accent color rather than a fixed alpha(white, 0.3), which was invisible on light backgrounds, and .welcome button.link no longer forces white text. A prefers-contrast: more block thickens the entry border and focus ring. Fixes sonnyp#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #218 as requested. Fixes #96.
default, so libadwaita follows theorg.freedesktop.appearanceportal: color scheme, accent color and contrast. GNOME, KDE Plasma and others implement it.color-schemekey whose values matchAdwColorSchemeso they can be passed straight toset_color_scheme.@popover_bg_color,@view_bg_color,@bordersand@accent_*.@popover_bg_coloris within a shade of the old#353433in dark, and gives a sane light appearance.alpha(white, 0.3), which was invisible on light backgrounds..welcome button.linkno longer forces white text, which was invisible on a light background.prefers-contrast: moreblock thickens the entry border and focus ring.Note: if #219 lands first this will have a trivial merge conflict in
window.blp(the removedPopoverMenublock sits right above the menu); happy to rebase.