Skip to content

Fix isolated margin ntli encoding#150

Open
boyi wants to merge 2 commits into
sonirico:masterfrom
boyi:fix-update-isolated-margin-ntli-int
Open

Fix isolated margin ntli encoding#150
boyi wants to merge 2 commits into
sonirico:masterfrom
boyi:fix-update-isolated-margin-ntli-int

Conversation

@boyi

@boyi boyi commented May 30, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Brief description of the changes in this PR.

Type of Change

  • [*] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement

Testing

  • [ *] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run make test and all checks pass

Code Quality

  • [* ] My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Generated Code

  • [* ] I have run make generate and committed any generated files
  • Generated files are up to date with struct changes

Breaking Changes

If this is a breaking change, please describe the impact and migration path for existing users:

Screenshots (if applicable)

Add screenshots to help explain your changes.

Additional Notes

Any additional information that would be helpful for reviewers.

Comment thread exchange.go
return nil
}

func isAPIResponseTarget(result any) bool {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it would change the default behavior.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to be sure about changes submitted in PRs, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants