Packaging: add PyInstaller script#549
Open
terrychan999 wants to merge 1 commit intosolvcon:masterfrom
Open
Conversation
Member
|
Would it make the total CI time longer to add an action for it? |
yungyuc
requested changes
Jun 18, 2025
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
- Add more error handling.
- Clarify if
pilotbinary works.
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | ||
| cd "$SCRIPT_DIR/../.." | ||
|
|
||
| python3 -m pip install pyinstaller |
Member
There was a problem hiding this comment.
Please check if pip install fails
| launch() | ||
| EOF | ||
|
|
||
| pyinstaller --onedir \ |
Member
There was a problem hiding this comment.
Would pilot work with this installation? pilot is the primary entry point of modmesh.
Member
|
@terrychan999 Please also take it to the discord #solvcon channel for quick discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we proposed a PyInstaller packaging script.
Currently only packaging the Python part of modmesh into a macOS app.
Maybe we could turn the line
make cleaninto a toggle to decide whether we wants to build the C++ part or not before the packaging started.