Conversation
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
It looks nice and it is time for us to make tests for the UI code. Do you have an idea for how to write Python unit tests for it?
| using Qt3DExtras::QOrbitCameraController::QOrbitCameraController; | ||
| }; /* end class ROrbitCameraController */ | ||
|
|
||
| class RCustomCameraController |
There was a problem hiding this comment.
Even though this is prototype code, we may use a descriptive name for the class. What name would be informative?
There was a problem hiding this comment.
hmm, I don't know, I think it depends on the behavior of the camera? like orbital or FPS
There was a problem hiding this comment.
How would you like the camera to behave (move)?
I've never wrote unit tests for UI, maybe try pytest-qt? |
If it does not take a lot of time (like more than 4 hours), it is a good idea to give it a try. |
3 participants
As mentioned in issue #70, the current camera control needs improvement. This pull request aims to create our own camera controller class derived from
QAbstractCameraControllerto better suit our requirements. At this point, the code introduces a new camera controller to the menu, which functions in the same way as theRFirstPersonCameraController. Further discussion is needed to determinte which functions should be added to the controller.