Restore easypost functionality - #112
Open
rahulsingh321 wants to merge 15 commits into
Open
rahulsingh321 wants to merge 15 commits into
rahulsingh321 wants to merge 15 commits into
Conversation
The EasyPost 5.0 gem changed the way the client object is instantiated, requiring the creation of a client that holds the API key and routing all easypost calls through that client. This change updates the gem's config to make the API key part of the configuration, and create a client on instantiation that can be used to make calls to Easypost.
The way this method is invoked as changed substantially as part of the changes to Easypost in 5.0. Instead of calling .buy on the shipment, .buy is now called via the client - passing in the shipment and rate IDs to purchase.
Solidus has changed their branches from master to main.
... otherwise rspec crashes during initialization because this required configuration option is missing.
On current versions of FactoryBot, calling .modify crashes unless you have already called .define and created the factory elsewhere.
…ntrib#111 The buy_easypost_rate method is being called twice, causing exception: EasyPost::Errors::InvalidRequestError (Postage already exists for this shipment.):
|
Partial Fix to #111 |
This was referenced Jan 7, 2025
|
@kennyadsl @tvdeyen @jarednorman this is waiting for a review for weeks now. Could somebody review it or tell us to keep it in a private repo. |
Member
|
@fthobe the change is welcome but it's a WIP draft PR, with specs failing. I'm afraid that if we review it now, it will change again after it will be in a mergiable state. |
rahulsingh321
changed the title
rahulsingh321
marked this pull request as ready for review
January 23, 2025 03:55
rahulsingh321
force-pushed
the
issue/108/upgrade_easypost_to_5
branch
from
January 23, 2025 05:35
e5d8b59 to
2f3ae70
Compare
|
@rahulsingh321 My draft PR might help you 🙂 |
rahulsingh321
force-pushed
the
issue/108/upgrade_easypost_to_5
branch
from
January 29, 2025 19:53
d869f24 to
56b1288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #111