Convert clients/js-legacy to oxlint and oxfmt#115
Open
clankmaxxing-clod wants to merge 1 commit into
Open
Conversation
Replace ESLint + Prettier with oxlint and oxfmt for the js-legacy client. - package.json: swap eslint/prettier/typescript-eslint devDependencies for oxlint and oxfmt; repoint lint/lint:fix/format/format:fix scripts; drop the "prettier" config key. - Add .oxlintrc.json mirroring the previous ESLint config: correctness rules as errors, consistent-type-imports enforced, ban-ts-comment / no-explicit-any / no-unused-vars / no-empty-object-type disabled, and import/extensions (via the import plugin) replacing eslint-plugin-require-extensions, still disabled for test/examples. - Add .oxfmtrc.json migrated from @solana/prettier-config-solana (printWidth 120, tabWidth 4, single quotes, semicolons, avoid arrow parens). - Remove .eslintrc and .eslintignore. The Makefile CI targets call `pnpm lint` / `pnpm format`, so no workflow changes are needed. Verified: lint, format --check, build, and tests all pass; existing source is already oxfmt-clean (no reformatting). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joncinque
approved these changes
Jul 23, 2026
Contributor
|
@lorisleiva can you take a quick look to make sure the clanker did the right thing? If it's good, I'll likely do the same for the other legacy js clients |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces ESLint + Prettier with oxlint and oxfmt for the
clients/js-legacypackage.Changes
package.json: droppedeslint,prettier,@typescript-eslint/*,eslint-config-prettier,eslint-plugin-prettier,eslint-plugin-require-extensions, and@solana/prettier-config-solana; addedoxlintandoxfmt. Scripts now run the Oxc tools:lint→oxlint --max-warnings 0lint:fix→oxlint --fixformat→oxfmt --check src testformat:fix→oxfmt --write src test"prettier"config key..oxlintrc.json(new) mirrors the old ESLint config:correctnesscategory as errors;consistent-type-importsenforced;ban-ts-comment/no-explicit-any/no-unused-vars/no-empty-object-typedisabled;import/extensions(import plugin) replaceseslint-plugin-require-extensionsand stays disabled fortest/examples..oxfmtrc.json(new) migrated from@solana/prettier-config-solanaviaoxfmt --migrate=prettier(printWidth 120, tabWidth 4, single quotes, semicolons,arrowParens: avoid)..eslintrcand.eslintignore.Notes
pnpm lint/pnpm formatthrough the repoMakefile, so no workflow files needed changing.oxfmt-clean — no source reformatting in this PR.Verification
pnpm lint,pnpm format,pnpm build, andpnpm test(7 passing) all succeed.🤖 Generated with Claude Code