Conversation
febo
force-pushed
the
collections-crate
branch
2 times, most recently
from
693a279 to
83a6398
Compare
|
The |
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great overall! Mostly small points
|
@joncinque Ready for a second review. About the name, the best I could come up was |
@lorisleiva seems to prefer |
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just some nits that you can take or leave
| @@ -0,0 +1,27 @@ | |||
| [package] | |||
| name = "spl-collections" | |||
There was a problem hiding this comment.
If we're good with the name, let's reserve it on crates.io!
There was a problem hiding this comment.
@lorisleiva has another suggestion: solana-wire-types
There was a problem hiding this comment.
that would confuse with networking types though, no?
There was a problem hiding this comment.
Good point, let's keep it collections then.
2 participants
Problem
Client generation need custom types to support
StringandVecto have different prefix length types – e.g., aStringwith au8length prefix or aVec<Address>without a prefix that consumes the remaining available bytes.Solution
Add a new crate to include custom
StringandVectypes with borsh and wincode serialization support.