Repository navigation
deps: Bump mollusk-svm to 0.17 - #16
Merged
Merged
Conversation
Mollusk 0.17 uses solana-account 5 and depends on agave 4.4, which requires rustc 1.98.1. Bump the matching dependency and toolchains. Agave 4.4 ships `sol_sha512` (SIMD-0512) and Mollusk enables it by default, so remove the local SHA-512 syscall shim from the Mollusk tests, as its comment asked. The shim also no longer compiled against solana-sbpf 0.24, which dropped the `memory_mapping` argument from `declare_builtin_function!`. The newer nightly's clippy flags `chunks_exact_mut(8)` with `chunks_exact_to_as_chunks`; use `as_chunks_mut::<8>()` instead. Compute units for the Mollusk test corpus are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joncinque
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mollusk-svmis on 0.13.1, and the latest release is 0.17.1.Summary of changes
mollusk-svmfrom 0.13.1 to 0.17.1, andsolana-accountfrom 3.4 to 5.0 to match it.Cargo.lockis updated withcargo update -p mollusk-svm.rust-toolchain.tomlgoes from 1.93.1 to 1.98.1. The pinned nightly in theMakefilegoes fromnightly-2026-01-22tonightly-2026-07-16.sol_sha512test shim: agave 4.4 implementssol_sha512(SIMD-0512, gated byenable_sha512_syscall), and Mollusk's default feature set enables it. The shim's own comment said to remove it once the runtime provides the syscall. It also stopped compiling, becausesolana-sbpf0.24 dropped thememory_mappingargument fromdeclare_builtin_function!. This PR removes the shim, its helper functions and its registration fromprogram/tests/mollusk.rs, along with the now-unusedsolana-program-runtimeandsolana-sha512-hasherdev-dependencies ofprogram.solana-sha512-hasherstays in the workspace fored25519-verify. The README note about the shim is updated.chunks_exact_to_as_chunksfor thechunks_exact_mut(8)loops ined25519-verify. They now useas_chunks_mut::<8>(), which is stable since Rust 1.88; the platform tools for the pinned CLI 4.1.2 use Rust 1.89. Two of the call sites are on-chain code, so I compared the compute units the Mollusk tests print before and after: all 46 torsion and corpus cases are identical (corpus total 121,881 CUs).Testing
Locally:
make build-sbf-{program,ed25519-verify}with the pinned Solana CLI 4.1.2make test-{program,ed25519-verify}: the Mollusk SBF tests run against the runtime's nativesol_sha512make clippy-*with the new nightlycargo fmt --checkandmake audit🤖 Generated with Claude Code