Skip to content

fix(web): stop the filter count appearing twice on the transactions toolbar - #1097

Merged
tobySolutions merged 6 commits into
mainfrom
fix/filter-count-badge-contrast
Aug 6, 2026
Merged

fix(web): stop the filter count appearing twice on the transactions toolbar#1097
tobySolutions merged 6 commits into
mainfrom
fix/filter-count-badge-contrast

Conversation

@tobySolutions

@tobySolutions tobySolutions commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

The transactions toolbar rendered the active filter count twice on the same condition: a badge on the Filters button, and an "N active" line directly beneath it. The badge was the weaker of the two — a bare number crowded against the button edge, beside a line that says what the number means and offers to clear it.

It was also unreadable in dark mode: it set text-white against bg-primary, which resolves near-white there, so the count sat white on white.

Removes the badge and keeps the line.

Note: #962 also touches this file, in a different region.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sdp-docs Ready Ready Preview Aug 6, 2026 3:26pm
sdp-web Ready Ready Preview Aug 6, 2026 3:26pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the redundant active-filter count badge from the transactions toolbar while retaining the descriptive “N active” row and clear action.

  • Leaves filter state and behavior unchanged.
  • Avoids the badge’s poor dark-mode contrast.

Confidence Score: 5/5

The code change appears safe to merge, though repository policy still requires the unsigned commits to be replaced with verified commits.

No blocking code failure remains in the reviewed change.

Important Files Changed

Filename Overview
apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx Removes only the duplicated count badge; the existing localized active-filter summary remains intact.

Reviews (8): Last reviewed commit: "Merge branch 'main' into fix/filter-coun..." | Re-trigger Greptile

@tobySolutions
tobySolutions merged commit 397cae7 into main Aug 6, 2026
34 checks passed
@tobySolutions
tobySolutions deleted the fix/filter-count-badge-contrast branch August 6, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants