Skip to content

chore: finalize world cup bracket teams#615

Merged
amilz merged 1 commit into
mainfrom
chore/finalize-bracket
Jun 29, 2026
Merged

chore: finalize world cup bracket teams#615
amilz merged 1 commit into
mainfrom
chore/finalize-bracket

Conversation

@amilz

@amilz amilz commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

update world cup example w/ final world cup team & tests

@amilz amilz requested a review from dev-jodee June 28, 2026 15:44
@amilz amilz self-assigned this Jun 28, 2026
@greptile-apps

greptile-apps Bot commented Jun 28, 2026

Copy link
Copy Markdown

Greptile Summary

This PR finalizes the World Cup example bracket data. The main changes are:

  • Separates fixed FIFA seed labels from real team display names.
  • Replaces the default team list with the final 32 bracket teams.
  • Adds country-code mappings for newly listed teams in the webapp.
  • Updates tests for the final team-to-seed slot mapping.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
games/world-cup/pinocchio/clients/typescript/src/fifa-2026.ts SLOT_LABELS now consistently store FIFA group-position seeds, with validation for the seed format.
games/world-cup/pinocchio/clients/typescript/src/teams.ts TEAM_NAMES now contains the final 32 display teams while preserving bracket slot order.
games/world-cup/pinocchio/webapp/src/components/bracket/teams.ts The webapp team-code map now includes codes for the newly added final bracket teams.
games/world-cup/pinocchio/clients/typescript/test/fifa-2026.test.ts Tests now check seed labels, distinct team names, and each final team-to-seed slot.
games/world-cup/pinocchio/clients/typescript/test/bracket-display.test.ts Display-name tests now expect finalized team names instead of seed placeholders.

Reviews (2): Last reviewed commit: "chore: finalize world cup bracket teams" | Re-trigger Greptile

@amilz amilz force-pushed the chore/finalize-bracket branch from 7cd684d to 1327763 Compare June 29, 2026 14:51
@amilz amilz merged commit 032bdf0 into main Jun 29, 2026
9 checks passed
@amilz amilz deleted the chore/finalize-bracket branch June 29, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants