feat(review): lay out the monthly letter as theme, stats and suggestion - #548
Open
AlexisEvan wants to merge 4 commits into
Open
AlexisEvan wants to merge 4 commits into
AlexisEvan wants to merge 4 commits into
Conversation
The monthly letter rendered as one block of prose even after the backend split it into parts, so the month had no shape at a glance. The card now renders the theme, the month's numbers, the body and one suggestion for next month as separate blocks. - Theme decides whether the structured blocks show at all: a weekly letter, a month too quiet to name a theme and a letter written before the split all leave it null and render body-only, which is the one rule that covers every case. tasksCompleted is counted live and always has a value, so it cannot carry that signal - The stats row renders whichever stats it was given rather than a fixed three: days active has no data source yet and focused minutes is deferred - The weekly review is untouched — the new blocks are gated to monthly - A quiet period now keeps its next-period suggestion instead of dropping it, so a low-activity month still closes on something to try Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Test Results126 tests 126 ✅ 24s ⏱️ Results for commit 0c044e3. ♻️ This comment has been updated with latest results. |
Contributor
|
Collaborator
Author
|
Collaborator
Author
quiet month |
sol-wizard
reviewed
Sep 18, 2026
sol-wizard
reviewed
Sep 18, 2026
sol-wizard
reviewed
Sep 18, 2026
sol-wizard
reviewed
Sep 18, 2026
- Hide the tasks-completed stat when the count is 0 - Treat missing theme/suggestion fields as absent (!= null) for older APIs - Give the quiet-period suggestion several examples and ask the model to vary it - Correct comments on when theme and oneThingToTryNext are null Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sol-wizard
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The monthly letter rendered as one block of prose even after the backend split it into parts. It now renders as separate blocks: the theme, the month's numbers, the body, and one thing to try next month.
tasksCompletedis counted live and always has a value, so it cannot carry that signalRelease note
Status: