Skip to content

fix: suppress AI error on sheet dismissal - #547

Merged
sol-wizard merged 2 commits into
mainfrom
fix/1524-ai-sheet-dismiss-toast
Sep 18, 2026
Merged

sol-wizard merged 2 commits into
mainfrom
fix/1524-ai-sheet-dismiss-toast

Conversation

@Armin1019

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1524.

Prevents intentional AI sheet dismissal from being treated as a generation failure. When the sheet is closed during an in-progress text or voice request, the canceled request now exits silently without showing an error toast or tracking ai_task_generation_failed.

Genuine request failures while the sheet is still open continue to use the existing error handling.

Release note

Closing the AI task generator while it is still working no longer shows an incorrect error message.

Status:

  • User-facing — announce it
  • Beta / partial — announce, but tagged as beta
  • Hidden in production (feature-flagged / not enabled for users) — don't announce
  • Internal only (refactor / infra / tests / CI / deps) — don't announce

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Test Results

126 tests   126 ✅  9s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 79734f7.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor
Package Line Rate Branch Rate Complexity Health
BlotzTask 4% 34% 2743
BlotzTask 4% 34% 2743
Summary 4% (4584 / 113766) 34% (968 / 2830) 5486

sol-wizard added a commit that referenced this pull request Sep 18, 2026
Reverts 8519fa0. The same bug is already fixed by the approved,
not-yet-merged PR #547 (same file, same approach), so keeping it here
would only conflict with it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sol-wizard
sol-wizard merged commit 9011060 into main Sep 18, 2026
4 checks passed
@sol-wizard
sol-wizard deleted the fix/1524-ai-sheet-dismiss-toast branch September 18, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants