fix(ci): reject placeholder release notes and multiple ticked status boxes - #538
Open
sol-wizard wants to merge 1 commit into
Open
sol-wizard wants to merge 1 commit into
sol-wizard wants to merge 1 commit into
Conversation
…boxes The check only verified that the heading existed and that at least one checkbox was ticked, so a PR keeping the untouched template placeholder as its release note still passed (and fed nothing usable to the release-notes generator). Now it also requires a real '>' note line — placeholder text fails, "none" passes — and exactly one ticked Status box, counted within the Release note section only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Test Results98 tests 98 ✅ 12s ⏱️ Results for commit 5f1c898. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-release-note-check.ymlonly checked that the## Release noteheading existed and that at least one checkbox was ticked — so a PR that left the untouched template placeholder as its release note still passed (e.g. #534), and the release-notes generator got nothing usable. Now the check also fails when:>note line is missing, empty, or still the template placeholder (noneis still accepted)Script logic tested locally against 8 body variants (placeholder, reworded placeholder,
none, missing quote, 0/2 ticks, summary checklists). This PR's own check run exercises the new version.Release note
Status: