Add Linux packaging scripts and desktop entry for Cheating Daddy#75
Open
sebamar88 wants to merge 13 commits intosohzm:masterfrom
Open
Add Linux packaging scripts and desktop entry for Cheating Daddy#75sebamar88 wants to merge 13 commits intosohzm:masterfrom
sebamar88 wants to merge 13 commits intosohzm:masterfrom
Conversation
sebamar88
commented
Jul 11, 2025
sebamar88
commented
- Updated package.json to include Linux build commands for .deb, .rpm, and AppImage targets.
- Added post-installation script to update desktop database, icon cache, and MIME database after installation.
- Added post-removal script to update desktop database and icon cache after removal.
- Added pre-removal script to display a message before removing the application.
- Created a .desktop file for Cheating Daddy to integrate it into the applications menu with appropriate metadata.
- Updated package.json to include Linux build commands for .deb, .rpm, and AppImage targets. - Added post-installation script to update desktop database, icon cache, and MIME database after installation. - Added post-removal script to update desktop database and icon cache after removal. - Added pre-removal script to display a message before removing the application. - Created a .desktop file for Cheating Daddy to integrate it into the applications menu with appropriate metadata.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… script for better structure
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Linux packaging support for Cheating Daddy, including build scripts, Debian installer hooks, and desktop integration.
- Introduces new npm scripts and Makefile targets for building
.deb,.rpm, and AppImage packages - Adds Debian lifecycle scripts (
postinst,prerm,postrm) and a.desktopentry for applications menu integration - Updates Electron Forge configuration plus documentation (
README.md,LINUX_INSTALL.md,PACKAGING_SUMMARY.md) to reflect Linux installation
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/assets/cheating-daddy.desktop | Desktop entry metadata for menu integration |
| scripts/prerm, scripts/postinst, scripts/postrm | Debian package pre- and post-install/removal scripts |
| package.json | New make:linux, make:deb, make:rpm, make:appimage scripts |
| forge.config.js | Configured Linux makers (deb, rpm, AppImage) |
| Makefile | Build targets for all Linux package formats |
| README.md, LINUX_INSTALL.md, PACKAGING_SUMMARY.md | Documentation updates for Linux packaging and installation |
Comments suppressed due to low confidence (2)
PACKAGING_SUMMARY.md:9
- Update this entry to reflect that RPM packaging support has now been implemented (maker-rpm added) or adjust the status indicator accordingly.
- **❌ .rpm package** - Requires `rpmbuild` (not installed on your system)
LINUX_INSTALL.md:33
- The AppImage filename pattern in documentation uses hyphens but elsewhere artifacts include spaces (e.g., "Cheating Daddy-*.AppImage"). Align this step with actual filenames or escape spaces.
chmod +x Cheating-Daddy-*.AppImage
| }, | ||
| }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
The RPM maker config is missing desktopTemplate and scripts entries (postinst, prerm, postrm) to install the desktop file and hook scripts—add these to mirror the Debian maker setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.