Use -Yfuture-lazy-vals for Scala 3 on the JVM - #486
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
-Yfuture-lazy-valsto Scala 3 on the JVM, so that JVM 25 no longer warns about a terminally deprecated API. Same change as softwaremill/sttp#2996.The flag needs the
VarHandleAPI, so it comes with-java-output-version 11. Scala 3 artifacts now need Java 11; Scala 2 artifacts are unchanged and still target Java 8.Also bumps sbt-mima-plugin 1.1.6 -> 1.2.0. The new lazy val encoding adds static
VarHandlefields to an object, which flips its static initialiser from public to private. MiMa 1.1.6 reads that as a removed method and fails onsttp.model.Header.<clinit>; 1.2.0 ignores class initialisers, which are never callable from user code anyway. A plugin bump rather than an exclusion, so nothing real gets hidden.Checked:
mimaReportBinaryIssuespasses against 1.7.18, andcore3/testpasses.