Only accept a retry value made up of ASCII digits - #485
Merged
Merged
Conversation
Such a line used to set retry back to None, dropping a value parsed from an earlier line of the same event. The spec says to ignore the field instead, so the earlier value is now kept.
The spec allows nothing else. A signed value such as `retry: -1` used to parse, giving a negative reconnect delay, and could overwrite a valid value read from an earlier line of the same event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things were wrong with how
ServerSentEvent.parsereads aretry:line. The spec says the value must be ASCII digits only, and that the field is ignored otherwise.An unreadable value used to reset
retrytoNone, dropping a value from an earlier line of the same event:A signed value used to parse, so a consumer could get a negative reconnect delay:
Both now ignore the line and keep whatever was read before.
A note on the digit check:
Integer.parseIntaccepts non-ASCII digits, and so doesCharacter.isDigit, soretry: ٥parsed toSome(5). The check is an explicit'0'to'9'range for that reason.toIntOptionis still needed after it, to reject a value too long to fit anInt.Found while reviewing #478, but unrelated to it.