Canvas Integration Tests (at long last)#651
Conversation
# Conflicts: # src/main/java/edu/byu/cs/canvas/model/CanvasSection.java
refactor: switched to mysql instead of memory
… when it already had access to the value
…f leaving them null
|
I didn't see the tests running in the actions, were you planning to do that in this PR? Also, if it does run in the actions, will it print student data when something goes wrong? We need to make sure to sensor that. |
mewilker
left a comment
There was a problem hiding this comment.
I believe these tests are good. We still need to integrate this into the pipeline, as well as address the comments mentioned above, but I know @bsharplydian is itching to be done with this work.
| LOGGER.error("Could not get Net IDs from current section: {}", e.getMessage()); | ||
| fail("Exception thrown: ", e); | ||
| } | ||
| assertNotNull(netids); |
There was a problem hiding this comment.
In addition to checking to see if netids is not null, should we also check to make sure it has a list of greater than 1 student? This way we are ensuring that it is grabbing multiple net IDs?
ZakkeryDaRebel
left a comment
There was a problem hiding this comment.
It all looks good, I just had 1 comment on one of the tests to ensure it is returning multiple like the test states. But it isn't all that required. Other than that, everything looked good.
Overview
Added further Canvas integration tests, with several dependencies. Resolves #65. Resolves #649.
Details
Testing
Future Work