Skip to content

Canvas Integration Tests (at long last)#651

Open
bsharplydian wants to merge 18 commits into
softwareconstruction240:mainfrom
bsharplydian:main
Open

Canvas Integration Tests (at long last)#651
bsharplydian wants to merge 18 commits into
softwareconstruction240:mainfrom
bsharplydian:main

Conversation

@bsharplydian

Copy link
Copy Markdown

Overview

Added further Canvas integration tests, with several dependencies. Resolves #65. Resolves #649.

Details

  • wrote tests for each of the CanvasIntegrationImpl functions.
  • coverage: 100% Class, 96% Method, 90% Line, and 60% Branch.
  • added default values for RubricConfigDao
  • thoroughly investigated the possibility of getting course information at runtime instead of using hardcoded values (I think it's possible and I opened an issue for it)

Testing

  • Added/updated unit tests
  • Tested edge cases
  • Manual testing (if needed)

Future Work

@mewilker

mewilker commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

I didn't see the tests running in the actions, were you planning to do that in this PR? Also, if it does run in the actions, will it print student data when something goes wrong? We need to make sure to sensor that.

@mewilker mewilker requested a review from a team June 5, 2026 18:44

@mewilker mewilker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these tests are good. We still need to integrate this into the pipeline, as well as address the comments mentioned above, but I know @bsharplydian is itching to be done with this work.

LOGGER.error("Could not get Net IDs from current section: {}", e.getMessage());
fail("Exception thrown: ", e);
}
assertNotNull(netids);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to checking to see if netids is not null, should we also check to make sure it has a list of greater than 1 student? This way we are ensuring that it is grabbing multiple net IDs?

@ZakkeryDaRebel ZakkeryDaRebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good, I just had 1 comment on one of the tests to ensure it is returning multiple like the test states. But it isn't all that required. Other than that, everything looked good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically configure Rubric Config values in memory backend: create tests for Canvas integration

3 participants