Conversation
Adds a runtime suite for the native gradient path: smooth interpolation of compatible gradients, to-only keyframes with and without an underlying gradient, explicit none and empty keyframes at every offset, discrete switching for different stop counts, linear vs radial and layer counts, natural completion and forwards fill, transitions adding and removing a gradient with and without allow-discrete, and platform-color stops. Adds the Background Image example screen and documents when gradients interpolate smoothly and when they switch discretely.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds runtime coverage for CSS Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to The added runtime coverage change has no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 0591106a-fcdb-4a19-b645-69e6f2bfb37f
📒 Files selected for processing (6)
apps/common-app/runtime-tests/reanimated/suites.tsapps/common-app/runtime-tests/reanimated/tests/props/cssBackgroundImage.test.tsxapps/common-app/src/apps/css/examples/animations/routes/properties/base.tsapps/common-app/src/apps/css/examples/animations/screens/animatedProperties/base/appearance/BackgroundImage.tsxapps/common-app/src/apps/css/examples/animations/screens/animatedProperties/base/appearance/index.tsdocs/docs-reanimated/docs/guides/supported-properties.mdx
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · Hide the Background Image route on Web. · base.ts:155-158
apps/common-app/src/apps/css/examples/animations/routes/properties/base.ts:155-158
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winHide the Background Image route on Web.
labelTypesonly renders badges, so this route remains reachable withoutdisplayed: !IS_WEB. The supported-properties documentation marksbackgroundImageas unsupported on Web. Add the established Web visibility guard to prevent users from opening an unsupported example.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 97d6ddb2-d176-4b81-a3af-8a1bc6469a56
📒 Files selected for processing (1)
apps/common-app/runtime-tests/reanimated/tests/props/cssBackgroundImage.test.tsx
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.
|
Closing: the backgroundImage feature stays in #10193; the runtime suite, example and docs changes from here become commits on that branch. |
Note
This pull request was authored by AI on behalf of @MatiPl01.
Summary
Covers the native
backgroundImageanimation path added in #10590:cssBackgroundImageon-device suite: smooth interpolation of compatible gradients,to-only keyframes with and without an underlying gradient, explicitnoneand[]at every offset, discrete switching for a different stop count, linear vs radial and a different layer count, natural completion and forwards fill, transitions that add or remove a gradient with and withoutallow-discrete, and platform-color stops,Test plan
27 tests, green on iOS (iPhone Air, iOS 26.5, Release) and Android (API 34 emulator, Debug). The example screen is
CSS animations > Animated properties > Appearance > Background Image.Changelog
No package code changes.