Chore: remove all warnings - #1008
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The warning-related changes are consistent with surrounding contracts and call-site guards.
Pull request overview
Removes compiler warnings by aligning runtime configuration, type specs, component attributes, and conditional rendering.
Changes:
- Makes unit-test detection runtime-configurable.
- Corrects stream query return types and removes unreachable error handling.
- Resolves component attribute and rendering warnings.
File summaries
| File | Description |
|---|---|
config/config.exs |
Enables unit-test mode in test configuration. |
lib/live_debugger/env.ex |
Reads unit-test state from application configuration. |
lib/live_debugger/app/web/components.ex |
Allows the button type attribute. |
lib/live_debugger/app/debugger/streams/queries.ex |
Corrects the return contract and removes unreachable handling. |
lib/live_debugger/app/debugger/callback_tracing/web/components/trace.ex |
Removes a redundant error-presence check. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.