Skip to content

feat: support fontFamily in linkVariants - #861

Merged
eszlamczyk merged 2 commits into
software-mansion:mainfrom
pingdotgg:link-pill/font-family
Sep 24, 2026
Merged

eszlamczyk merged 2 commits into
software-mansion:mainfrom
pingdotgg:link-pill/font-family

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

What/Why?

Allow LinkVariantStyle.fontFamily to override the existing base link family for matching URLs. Omitted values inherit the base family. Both native renderers and ordinary web links use the resolved family, and the public style type is exported from the package root.

This is the independent foundation of the proposed native pill extension. It does not enable pill presentation.

Refs #860. This first layer is independent; the native pill #862 and optional tint #863 layers follow separately.

Testing

  • TypeScript and all 7 Jest suites / 42 tests passed, including native/web normalization and ordinary web link rendering.
  • Bob module/declaration build and iOS/Android code generation passed.
  • Scoped ESLint, clang-format and whitespace checks passed.
  • Normal repository commit hooks passed. Exact standalone native-device proof is not claimed.
  • Isolated library example/E2E and native XCTest were not run. Combined-consumer native proof is contextual evidence for the later pill layers, not proof of this isolated head.

PR Checklist

  • Code compiles and runs on iOS
  • Code compiles and runs on Android
  • Updated documentation/README if applicable
  • Ran example app to verify changes
  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

@eszlamczyk eszlamczyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juliusmarminge change overall looks good! Just some small nitpicks I will fix myself and merge this after CI pass

@eszlamczyk
eszlamczyk merged commit 5c4e037 into software-mansion:main Sep 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants