Repository navigation
feat: support fontFamily in linkVariants - #861
Merged
eszlamczyk merged 2 commits intoSep 24, 2026
Merged
Conversation
This was referenced Sep 20, 2026
juliusmarminge
marked this pull request as ready for review
September 21, 2026 17:39
eszlamczyk
approved these changes
Sep 22, 2026
eszlamczyk
left a comment
Collaborator
There was a problem hiding this comment.
Hi @juliusmarminge change overall looks good! Just some small nitpicks I will fix myself and merge this after CI pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Allow
LinkVariantStyle.fontFamilyto override the existing base link family for matching URLs. Omitted values inherit the base family. Both native renderers and ordinary web links use the resolved family, and the public style type is exported from the package root.This is the independent foundation of the proposed native pill extension. It does not enable pill presentation.
Refs #860. This first layer is independent; the native pill #862 and optional tint #863 layers follow separately.
Testing
PR Checklist