feat(MapChartD3): create canvas based map chart with D3#109
Open
AregSoft wants to merge 14 commits intorelease/2.15.0from
Open
feat(MapChartD3): create canvas based map chart with D3#109AregSoft wants to merge 14 commits intorelease/2.15.0from
AregSoft wants to merge 14 commits intorelease/2.15.0from
Conversation
AregSoft
requested review from
GaroGabrielyan,
NairaMisakyan,
NarekArshakyan and
hamikhambardzumyan
as code owners
This was
linked to
issues
Mar 26, 2024
Closed
…ponents into feature/add-d3-map-chart
add tests for MapChartD3, resolve comments and fix ui bugs
…ene-ui-components into feature/add-d3-map-chart
Add tooltipRenderer prop to render tooltip for MapChartD3 and add unit tests
GaroGabrielyan
requested changes
May 15, 2024
refactor MapCharD3 component and resolve comments
AregSoft
requested review from
GaroGabrielyan,
NarekArshakyan and
arthur-grigoryan-softconstruct
| > | ||
| <div | ||
| className="popover__target" | ||
| style={{ position: 'absolute', left: `${tooltipData.left}px`, top: `${tooltipData.top}px` }} |
Contributor
There was a problem hiding this comment.
you can move position: 'absolute' in css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.