fix: match heading depths 1-6 in session-handoff validator#30
Open
CypherPoet wants to merge 1 commit intosoftaworks:mainfrom
Open
fix: match heading depths 1-6 in session-handoff validator#30CypherPoet wants to merge 1 commit intosoftaworks:mainfrom
CypherPoet wants to merge 1 commit intosoftaworks:mainfrom
Conversation
The heading-match regex `##?` only recognized `#` and `##`, causing
`###` headings (used by the handoff template's own nested structure)
to be flagged as missing. This expands the pattern to `#{1,6}` across
required-section detection, recommended-section detection, and the
next-section boundary used for content-length measurement.
Fixes softaworks#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21 — the
session-handoffvalidator's heading-match regex (##?) only recognized#and##headings. This caused###headings (which the handoff template's own nested structure uses for "Important Context" and "Immediate Next Steps") to be flagged as missing required sections.##?(#{1,2}) to#{1,6}in three locations: required-section detection, recommended-section detection, and the next-section boundary used for content-length measurement.#{{1,6}}in f-string contexts to produce the correct regex literal (bare{1,6}is interpreted as a format expression, not a quantifier).Test plan
validate_handoff.pyagainst the minimal reproduction case from session-handoff validator rejects valid ### headings in required sections #21 — all three required sections (Current State Summary,Important Context,Immediate Next Steps) should pass at###depthvalidate_handoff.pyagainst a handoff using##headings — no regression (existing behavior preserved)check_recommended_sectionsalso recognizes###+ headings