Repository navigation
Verify offline sandbox network denial on Linux - #309
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08d31ee578
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Issue: #245
The offline research profile already has attestation and receipt gates, but its Linux integration gate did not independently observe attempted network traffic from an approved executable run. This adds host-side TCP, UDP, DNS-protocol, and inherited-socket canaries around the attested bubblewrap child. The child attempts each path with proxy variables present; the test requires no host canary traffic, no inherited network descriptor, and no proxy variables. A separate negative test requires a mismatched attestation digest to stop before the child starts.
The documentation distinguishes resolver failure from observed network isolation and limits the result to the tested Linux runner. It does not claim that a separately deployed worker has been attested.
Validation at head
08eb536: localmake checkand the pinned push gate passed. The local host is Darwin, so the Linux runtime test skipped locally. Hosted Ubuntu ran all eight Linux bubblewrap integration tests successfully; the full PR check set, including CodeQL and security/quality gates, passed. The earlier P1 review finding (embedded NUL in the child script) was fixed in08eb536, verified by the hosted Linux run, and its thread resolved. Fresh Codex review of08eb536found no major issues. An independent focused review of the fix found no actionable issue.Remaining #245 acceptance: collect equivalent independent observation and pinned fixture playback on the production-configured Linux worker before claiming that deployment is no-egress. Keep the issue open for that evidence.