Skip to content

Harden offline research corpus preflight and feature evidence - #308

Merged
sodejm merged 2 commits into
mainfrom
codex/issue-245-review-fixes
Oct 15, 2026
Merged

sodejm merged 2 commits into
mainfrom
codex/issue-245-review-fixes

Conversation

@sodejm

@sodejm sodejm commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Problem and change

Offline research preflight could reject a frozen plan with an empty argument tuple and could block while opening a substituted FIFO corpus. Accept the immutable empty tuple, open corpus sources without waiting on a FIFO, and reject nonregular sources before staging. Add executable feature scenarios for the supported fixture behavior and document the limits of that evidence.

Refs #245. This increment does not close the issue: native Linux denied-egress, credential, socket, canary, and cleanup evidence is still required for the full acceptance criteria.

Validation and review

  • Focused offline research and feature-step tests: 21 passed.
  • Repository push gate on 62adf5a2fee10c1b46f4338322ce13772c9aadc6: passed make check, pinned Ruff checks, 2,196 pytest cases (20 skipped), coverage, and pip-audit.
  • Independent review found a fixture-evidence wording overclaim; the feature scenario wording was narrowed before this PR.
  • Native Linux isolation was not exercised in this checkout. The issue remains open for that evidence.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T05:04:01.857271Z 62adf5a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sodejm
sodejm merged commit f46baf8 into main Oct 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant