Repository navigation
Harden Linux host assessment import contract - #306
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53f58f7ff4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the offline Linux privilege-boundary assessment import for #106. Protection states are validated per control (including AppArmor complain mode), and oversized JSON integers return a contract error through both the API and CLI. The import contract, registered skill, architecture count, and specification now match the implemented capability.
This is an incremental offline importer change. A reported canary crossing is still evidence from an imported report, not a locally demonstrated privilege boundary crossing. Native disposable-host positive, negative, fixed, and cleanup evidence remains outstanding, so #106 should stay open.
Validation in this branch: 50 focused tests passed;
python3 -m cops check host-assessment-workbench, adapter synchronization, capability audit, andmake checkpassed. The pinned local push gate passed its full pytest coverage run, Ruff checks, and pip audit. No native Linux host run was performed.Security review considered malformed and hostile report input, protection-state ambiguity, and unsupported capability claims. The parser rejects invalid states and returns bounded contract failures; no executable host action or authorization surface was added.