Repository navigation
Conversation
Require a unique assessment for each canonical completed probe key before preparing specialist handoffs. Add a fail-closed regression and document the checkpoint rule. Forty-six focused tests and Ruff checks passed. Revert this commit to restore the prior handoff behavior; no external execution occurs.
…sue-285-service-validation
Signed-off-by: Justin Soderberg <723679+sodejm@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
A discovered service could previously stop at an evidence-bound specialist handoff. This change adds the public, bounded validation journey required by #285: discovery → selection/routing → authorization → protocol probe → independent verification → report → cleanup.
The disposable loopback lab registers seven explicitly lab-only adapters on nonstandard ports:
GET /healthPING; a separate authorization gatesECHOauthorized-useEHLOGET /versionProvider and verifier open separate connections and bind protocol, effect, and cleanup evidence to the exact endpoint, version, plan, attempt, timestamp, and evidence digest. Candidate, verified finding, and successful authorized use remain separate states. The #143 reproduction is loaded as trusted immutable data and its digest is bound to the exact Redis version, endpoint, controlled effect, and cleanup result. Authorization failure before dispatch releases the reserved attempt; replayed, stale, fabricated, mismatched, missing, or invalid evidence fails closed and remains
insufficient_evidence.Operator path and outcomes
Run:
The JSON report covers all seven routed families across eight loopback endpoints:
insufficient_evidence;These adapters are registered only inside the disposable lab. They do not provide or claim production external-target support. Provider and verifier use separate connections, but share the protocol parsing implementation; the journey therefore does not claim an independently implemented parser.
Validation
Reviewed and pushed revision:
999f25065059f3ae836f4abf3caa221a2ef63199(signed).python3.11 -m pytest -q tests/test_service_entry_validation.py tests/test_service_validation_execution.py tests/test_service_validation_lab.py tests/step_defs/test_service_entry_validation_steps.py— 52 passed.python3.11 scripts/service_validation_loopback_example.py— all seven families and all expected positive, remediated, and insufficient paths completed; every fixture cleaned up.make checkpassed;Hosted checks are evaluated separately.
Draft integration state
This PR remains draft until #299 merges. After that dependency lands, latest
mainwill be merged without rewriting signed history, the overlapping discovery contract will be reconciled, and the focused suite, public subprocess journey,make check, and normal push gate will be rerun at the final exact head.Refs #285