Repository navigation
fix: bound REPL history storage and startup memory - #513
Merged
Merged
Conversation
Read only a bounded history tail, retain the newest entries within count and byte limits, and compact history through private atomic replacements. Keep in-memory history bounded when persistence fails, and reject malformed, oversized, sensitive, or symlinked history input. Document retention, privacy, and threat-model implications, with regressions for legacy files, failure recovery, permissions, and replacement races. Validation: make test (3518 passed, 28 skipped), make lint, make typecheck. make security is blocked by an upstream Semgrep rule-bundle hash mismatch; dependency audit passed. This commit remains local pending the security gate. Refs #503
github-actions
Bot
added
documentation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REPL startup now reads a bounded history tail and retains at most 1,000 entries and 1 MiB, with a 16 KiB serialized-entry limit. Legacy compaction and subsequent writes use private temporary files and atomic replacement; failures preserve the original file and leave bounded session history available in memory. Sensitive-command filtering and restrictive permissions remain enforced.
The security gate also required refreshing the reviewed Python, secrets, and selected Trail of Bits registry snapshots. This is a separate signed commit with updated byte/semantic pins and contract tests; integrity failures still fail closed.
Closes #503.
Validation:
make pre-push: 3,520 passed, 28 skipped; 83.19% coverage; lint and type checks passed; dependency audit clean; Semgrep completed with zero findings.Architecture, threat-model, console, privacy, and CI documentation are updated. The change adds no provider calls or diagnostics containing command contents. API contracts and release artifact/provenance paths are unaffected.