Skip to content

docs: clarify setup, desktop support, and delivery workflows - #511

Merged
sodejm merged 4 commits into
mainfrom
bugfix/documentation-workflows
Oct 14, 2026
Merged

sodejm merged 4 commits into
mainfrom
bugfix/documentation-workflows

Conversation

@sodejm

@sodejm sodejm commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Summary

Make the documentation's setup, desktop support, navigation, contributor review, and release procedures usable without weakening the existing security or support boundaries.

  • Correct source setup order and runtime prerequisites.
  • Separate supported desktop onboarding from source-only previews and fictional fixtures.
  • Document reproducible release-readiness dispatch, exact-run evidence, and recovery commands.
  • Organize documentation around reader tasks and move desktop setup near the top.
  • Make exact-target Codex review steps and stop conditions explicit.
  • Clarify that the documentation inventory rejects every unclassified tracked file.

Acceptance criteria

Acceptance criterion Test or evidence
Source setup starts with clone and supported prerequisites README/tutorial review against bootstrap scripts; documentation architecture tests
Packaged desktop core and source gates remain distinct tests/test_desktop_learning_path_docs.py, tests/test_desktop_architecture_docs.py
Release commands identify exact workflow inputs and run evidence tests/test_release_contract.py; shell syntax and workflow/checker contract review
Reader tasks have consistent navigation and links make docs-cutover; wiki and Pages contract tests
Contributor review preserves trusted-base, immutable-target, and fail-closed rules tests/test_code_review_skill_contract.py; comparison with trusted-base skill
Every tracked file must be classified tests/test_code_documentation_policy.py; make code-docs-check

TDD evidence

No behavioral test applies because this change updates documentation and its location-sensitive contract assertions without changing application or workflow behavior. Existing support and security assertions remain enforced. The focused documentation regression suite passed all 296 tests.

Validation evidence

Command Result
Documentation, wiki, Pages, screenshots, release and review contract regression suite 296 passed
make markdown-check Passed: 87 files
make docs-cutover Passed on d4663d7: 63 pages, 22 assets, 71 wiki files, 59 external links, zero exceptions
make code-docs-check Passed Python and desktop documentation checks
.venv/bin/python scripts/validate_wiki_docs.py --source docs Passed
Screenshot manifest and published-asset validation Passed
New release shell commands: bash -n and local implementation comparison Passed
git diff --check origin/main..HEAD Passed
make pre-push Passed: 3,503 tests, 28 skipped; lint, type checking, dependency audit, and static security scan passed (zero findings)
make docs-screenshots-check macOS fails closed with DOCSHOT_ELECTRON_PLATFORM_UNSUPPORTED; hosted Ubuntu 24.04 x86_64 CI supplies canonical PNG drift validation
make workflow-audit Not applicable: no workflow changes

Risk and safety

Low risk. No runtime, API, dependency, architecture, or threat-model changes. Architecture and threat-model documents are unaffected because this patch clarifies existing behavior and boundaries. No release artifact is produced or altered.

Provider none remains network-free, cloud use still requires explicit selection and consent, the sidecar remains private and authenticated, and immutable RootsMagic/GEDCOM protections remain unchanged. Named provider, Tasks, Chat, and file-grant functionality remains gated on target-matched evidence. No secrets or private genealogy data are included.

The branch was created from current origin/main, uses the required bugfix/* prefix, and contains four signed commits. Hosted signature verification, CI, and exact-target Codex review will be checked before merge.

Put task navigation and setup first while retaining detailed security contracts in the desktop guide. Update metadata and documentation assertions for the supported installer and fictional preview distinction.

Documentation-only change: application behavior, architecture, and threat-model boundaries are unchanged; no failing application behavior test applies. The documentation regression suite passes all 296 tests.
Present the authoritative Codex review procedure as ordered steps and explicit delivery stops. State that every unclassified tracked path fails the documentation inventory, including non-comment formats.

Preserve review identity, revision, resolution, and security invariants. Documentation-only clarification; implementation and architecture are unchanged. Relevant documentation regression tests pass.
Document the required dispatch inputs, capture the returned run URL, and verify workflow identity, candidate SHA, completion, and downloaded evidence before continuing. Use the repository virtual environment for release recovery verification.

Preserve lifecycle audit and release provenance requirements. Shell examples pass bash syntax checks and match the workflow and publication contracts. Documentation-only; no workflow was dispatched and no application behavior changed.
@github-actions github-actions Bot added documentation Improvements or additions to documentation testing labels Oct 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T01:44:02.965540Z d4663d7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sodejm
sodejm enabled auto-merge (squash) October 14, 2026 01:39
@sodejm

sodejm commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: d4663d76b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sodejm
sodejm merged commit c321fd1 into main Oct 14, 2026
23 checks passed
@sodejm
sodejm deleted the bugfix/documentation-workflows branch October 14, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant