Skip to content

What is the proper way to update connectPayload on reconnection? #1506

Description

@ericgroom

So I have a client that passes auth and other info via the withPayload: parameter of SocketIOClient.connect. When I get a .reconnectAttempt client event, I want to update this payload to a new value. I see SocketIOClient stores this payload as connectPayload and passes it again, but the property is internal.

Calling SocketIOClient.connect within the event handler seems possible but like it has side effects. Same with SocketIOClient.joinNamespace. As I'm already reconnecting, I worry that calling one of these can cause a race condition in SocketManager._tryReconnect since they will call SocketManager.connect() internally before it is called in SocketManager._tryReconnect. Maybe unfounded, but nonetheless shouldn't there be a public way to update this value?

I think I can get around it by subclassing but that seems heavy handed...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions