Skip to content

chore: add more test fixtures for UFM SARIF rendering #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CatalinSnyk wants to merge 18 commits into
base: main
Choose a base branch
from
Open

chore: add more test fixtures for UFM SARIF rendering #505

CatalinSnyk wants to merge 18 commits into from

Conversation

@CatalinSnyk
Copy link
Contributor

@CatalinSnyk CatalinSnyk commented Dec 15, 2025 •
edited
Loading

  • Adding another fixture file for the SARIF rendering of UFM data
  • A few tweaks to the SARIF helpers logic to make it a bit more decoupled from SCA data

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@CatalinSnyk CatalinSnyk marked this pull request as ready for review December 15, 2025 16:12
@CatalinSnyk CatalinSnyk requested review from a team as code owners December 15, 2025 16:12
PeterSchafer and others added 13 commits December 19, 2025 13:14
@PeterSchafer @CatalinSnyk
chore: add test file that breaks the rendering
f3cc54b
@CatalinSnyk
chore: handle display target file optionality when building artifact …
8abd37e 
…locations
@CatalinSnyk
chore: fix broken automationDetailsId
78e90cc
@CatalinSnyk
chore: omit building fullDescriptions if not enough information is av…
26c3a15 
…ailable
@CatalinSnyk
chore: add expected SARIF for secret fixture
d21d179
@CatalinSnyk
chore: skip logical locations if not enough information is available
04435ef
@CatalinSnyk
chore: align test expectation with current implementation
e8af10d
@CatalinSnyk
chore: fix automationDetailsId generation
f1fd3fd
@CatalinSnyk
chore: make linter happy
51cbe36
@CatalinSnyk
chore: handle missing component name when building shortRule description
ffdab37
@CatalinSnyk
chore: use rule short description when available for building SARIF
e88dd14
@CatalinSnyk
chore: make data key more specific
7271c04
@CatalinSnyk
chore: update test expectations
5c4ef63
@CatalinSnyk CatalinSnyk force-pushed the chore/CLI-1287_secrets_sarif branch from 7272886 to 5c4ef63 Compare December 19, 2025 11:14
PeterSchafer
PeterSchafer reviewed Dec 19, 2025
View reviewed changes
PeterSchafer
PeterSchafer reviewed Dec 19, 2025
View reviewed changes
PeterSchafer
PeterSchafer reviewed Dec 19, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CatalinSnyk @PeterSchafer