Repository navigation
SNOW-4387808 Rotate the sfctest0 E2E key in profile.json - #1180
Merged
Merged
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
sfc-gh-aschuck
marked this pull request as ready for review
November 17, 2026 18:24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 58.98% 61.60% +2.62%
==========================================
Files 214 214
Lines 14674 14674
Branches 1614 1614
==========================================
+ Hits 8655 9040 +385
+ Misses 5375 4921 -454
- Partials 644 713 +69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-hmadan
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge yet. This is part of a coordinated credential rotation (internal ticket SNOW-4387808). It must merge
on the scheduled switch-over day, before the old key is removed from the test user.
What
Updates
profile.json.gpg(the AWS E2E profile) with a new private key for the E2E test usersnowpipe_sdk_gh_actiononsfctest0.private_keyvalue changed. Every other field is identical.PROFILE_JSON_DECRYPT_PASSPHRASE, which is not changing, so nosecret update is needed here.
profile_azure.json.gpgandprofile_gcp.json.gpguse a different user and key and are not affected.Why
The credentials for this test user are being rotated as part of an internal security task. This repo's E2E logs
in as the same user, so its copy of the key has to be updated too.
How it's sequenced
RSA_PUBLIC_KEY_2). The usercurrently accepts both the old and new keys, so
masterkeeps working.masterthen uses the new key.this file works. If this PR hasn't merged by then, E2E here fails to log in.
Rollback: until step 3, reverting this PR is enough. The old key still works.
Testing
sfctest0assnowpipe_sdk_gh_action.🤖 Generated with Claude Code